Skip to content

fix(prompt): add guidance to skip unrelated CI failures #18127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aliersh merged 1 commit into from
Nov 3, 2025
Merged

fix(prompt): add guidance to skip unrelated CI failures #18127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ops/ai-eng/contracts-test-maintenance/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.2.0
1.2.1
5 changes: 5 additions & 0 deletions ops/ai-eng/contracts-test-maintenance/prompt/prompt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,11 @@ contract L1FeeVault_Version_Test {
- MUST pass before creating any PR
4. Search for any vm.expectRevert() without arguments and fix them

**INTERPRETING CI STATUS:**
- Only investigate actual code failures: build errors, test failures, lint violations
- "Code Review Requirements" status = waiting for reviewer approvals, not code issues
- Test-only changes cannot affect these CI jobs - skip them: `diff-asterisc-bytecode`, `op-program-compat`

**ZERO TOLERANCE - CI FAILURES:**
- vm.expectRevert() must ALWAYS have arguments: either selector or bytes message
- ALL tests must pass - no exceptions
Expand Down