Skip to content

fix(op-batcher): exempt generic da from max input size #18074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastianst merged 2 commits into from
Oct 30, 2025
Merged

fix(op-batcher): exempt generic da from max input size #18074

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac9608f
fix(op-batcher): exempt generic da from max input size
tuxcanfly Oct 8, 2025
841715b
Apply suggestion from @sebastianst
sebastianst Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion op-batcher/batcher/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ type BatcherConfig struct {
// UseAltDA is true if the rollup config has a DA challenge address so the batcher
// will post inputs to the DA server and post commitments to blobs or calldata.
UseAltDA bool
// GenericDA is true if the DA server generates commitments for the input
GenericDA bool
// maximum number of concurrent blob put requests to the DA server
MaxConcurrentDARequests uint64

Expand Down Expand Up @@ -284,7 +286,7 @@ func (bs *BatcherService) initChannelConfig(cfg *CLIConfig) error {
return fmt.Errorf("cannot use data availability type blobs or auto with Alt-DA")
}

if bs.UseAltDA && cc.MaxFrameSize > altda.MaxInputSize {
if bs.UseAltDA && !bs.GenericDA && cc.MaxFrameSize > altda.MaxInputSize {
return fmt.Errorf("max frame size %d exceeds altDA max input size %d", cc.MaxFrameSize, altda.MaxInputSize)
}

Expand Down Expand Up @@ -428,6 +430,7 @@ func (bs *BatcherService) initAltDA(cfg *CLIConfig) error {
}
bs.AltDA = config.NewDAClient()
bs.UseAltDA = config.Enabled
bs.GenericDA = config.GenericDA
return nil
}

Expand Down