Skip to content

GasPriceOracle: remove saturating math from getOperatorFee (jovian) #17998

Merged
geoknee merged 1 commit intoproposal/op-contracts/v5.0.0from
gk/cherry-pick-jovian-gpo
Oct 24, 2025
Merged

GasPriceOracle: remove saturating math from getOperatorFee (jovian) #17998
geoknee merged 1 commit intoproposal/op-contracts/v5.0.0from
gk/cherry-pick-jovian-gpo

Conversation

@geoknee
Copy link
Copy Markdown
Contributor

@geoknee geoknee commented Oct 23, 2025

This cherry picks #17913 (already merged to develop) onto the release branch for op-contracts/v5.0.0 so we can cut a new RC.

…17913)

* GasPriceOracle: remove saturating math fro getOperatorFee (isthmus and jovian)

Extend test coverage to edge cases

* restore Isthmys formula

* fix test

* use library

* lint

* semver bump

* modify semver and regenerate lock file
@geoknee geoknee requested a review from a team as a code owner October 23, 2025 10:38
@geoknee geoknee requested a review from mds1 October 23, 2025 10:38
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.15%. Comparing base (aeed703) to head (f6e2e48).
⚠️ Report is 2 commits behind head on proposal/op-contracts/v5.0.0.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           proposal/op-contracts/v5.0.0   #17998      +/-   ##
================================================================
+ Coverage                         74.64%   81.15%   +6.51%     
================================================================
  Files                               174      119      -55     
  Lines                             11105     6320    -4785     
================================================================
- Hits                               8289     5129    -3160     
+ Misses                             2672     1191    -1481     
+ Partials                            144        0     -144     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 81.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ckages/contracts-bedrock/src/L2/GasPriceOracle.sol 100.00% <100.00%> (ø)

... and 55 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@geoknee geoknee merged commit d09c836 into proposal/op-contracts/v5.0.0 Oct 24, 2025
69 checks passed
@geoknee geoknee deleted the gk/cherry-pick-jovian-gpo branch October 24, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants