Skip to content

Address potential reentrancy vector on LivenessModule2#17975

Merged
mds1 merged 4 commits intodevelopfrom
acc/reentrancy-on-ownership-change
Oct 22, 2025
Merged

Address potential reentrancy vector on LivenessModule2#17975
mds1 merged 4 commits intodevelopfrom
acc/reentrancy-on-ownership-change

Conversation

@alcueca
Copy link
Copy Markdown
Contributor

@alcueca alcueca commented Oct 22, 2025

Very unlikely case, and against the assumptions on the spec, but still a style issue that might be raised by auditors.

@alcueca alcueca requested a review from a team as a code owner October 22, 2025 05:02
@alcueca alcueca requested a review from mbaxter October 22, 2025 05:02
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.36%. Comparing base (07a6044) to head (0943132).
⚠️ Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17975      +/-   ##
===========================================
+ Coverage    75.15%   81.36%   +6.21%     
===========================================
  Files          175      120      -55     
  Lines        11257     6472    -4785     
===========================================
- Hits          8460     5266    -3194     
+ Misses        2651     1206    -1445     
+ Partials       146        0     -146     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 81.36% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ges/contracts-bedrock/src/safe/LivenessModule2.sol 98.71% <100.00%> (ø)
packages/contracts-bedrock/src/safe/SaferSafes.sol 100.00% <ø> (ø)

... and 55 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alcueca alcueca requested review from AmadiMichael and Ethnical and removed request for mbaxter October 22, 2025 05:33
Copy link
Copy Markdown
Member

@JosepBove JosepBove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Ethnical
Copy link
Copy Markdown
Contributor

Ethnical commented Oct 22, 2025

why the livenessResponsePeriod is a uint256?
A smaller values like uint64 should be enough here no?

@Ethnical
Copy link
Copy Markdown
Contributor

LGTM, will approve when we fixed the semver as matt mentionned above.

@mds1 mds1 added this pull request to the merge queue Oct 22, 2025
Merged via the queue into develop with commit d3abbbd Oct 22, 2025
70 checks passed
@mds1 mds1 deleted the acc/reentrancy-on-ownership-change branch October 22, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants