op-challenger: Support retrieving the oracle and prestate via game args.#17958
Merged
op-challenger: Support retrieving the oracle and prestate via game args.#17958
Conversation
ajsutton
force-pushed
the
aj/challenger-game-args
branch
from
a0b693d to
7a375ce
Compare
mbaxter
reviewed
Oct 21, 2025
Inphi
approved these changes
Oct 21, 2025
Contributor
Inphi
left a comment
Inphi
left a comment
There was a problem hiding this comment.
Looks good.
Could we alsoupdate gamefactory_test.go to cover calls such as DisputeGameFactoryContract.GetGamePrestate for dispute-game v2 game args.
ajsutton
force-pushed
the
aj/challenger-game-args
branch
from
7a375ce to
7b05004
Compare
mbaxter
approved these changes
Oct 21, 2025
The implementation contract doesn't always have the values embedded.
ajsutton
force-pushed
the
aj/challenger-game-args
branch
from
7b05004 to
3d16ff3
Compare
theochap
pushed a commit
that referenced
this pull request
Oct 22, 2025
…gs. (#17958) The implementation contract doesn't always have the values embedded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The implementation contract doesn't always have the values embedded. It automatically switches between game args and reading from the implementation, as well as detecting versions that don't yet support game args for backwards compatibility.
The
GetGameImplmethod is now internal toDisputeGameFactoryto ensure that nothing is grabbing the game implementation and depending on its behaviour.DisputeGameFactoryexposes methods to get the VM or Prestate in a way that's compatible with game args.Tests
Updated tests. Smoke test that detected this is now enabled.
Metadata
fixes #17810