opcm-standard-validator: Re-enable tests for v2 contracts, validate proposer#17955
Merged
opcm-standard-validator: Re-enable tests for v2 contracts, validate proposer#17955
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #17955 +/- ##
===========================================
+ Coverage 74.85% 81.61% +6.76%
===========================================
Files 175 120 -55
Lines 11261 6494 -4767
===========================================
- Hits 8429 5300 -3129
+ Misses 2688 1194 -1494
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
eabcf5a to
56a3217
Compare
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
c62c90c to
518ed16
Compare
56a3217 to
761f7e5
Compare
Base automatically changed from
aj/creator-opcm-addGameType-rebuild
to
develop
October 21, 2025 21:01
c03bafc to
12bb004
Compare
Inphi
reviewed
Oct 22, 2025
packages/contracts-bedrock/src/L1/OPContractsManagerStandardValidator.sol
Show resolved
Hide resolved
packages/contracts-bedrock/src/L1/OPContractsManagerStandardValidator.sol
Show resolved
Hide resolved
Inphi
approved these changes
Oct 22, 2025
packages/contracts-bedrock/src/L1/OPContractsManagerStandardValidator.sol
Show resolved
Hide resolved
packages/contracts-bedrock/src/L1/OPContractsManagerStandardValidator.sol
Show resolved
Hide resolved
ajsutton
approved these changes
Oct 22, 2025
aa6238a to
b72325d
Compare
packages/contracts-bedrock/src/L1/OPContractsManagerStandardValidator.sol
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
OPContractsManagerStandardValidator:proposeronPermissionedDisputeGame'sGameTypevalidation since this was changed in proofs: Pass game type as a CWIA arg instead of a constructor arg #17832Additionally tests are reenabled and updated to handle the
DevFeatures.DEPLOY_V2_DISPUTE_GAMES.This PR builds on:
OPContractsManagerStandardValidatorto read some game parameters from the newgameArgsmapping inDisputeGameFactory.Tests
Tests have been re-enabled and updated.
Metadata
Closes #17267