Skip to content

opcm: Update upgrade method for disputegame-v2 #17874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajsutton merged 15 commits into from
Oct 21, 2025
Merged

opcm: Update upgrade method for disputegame-v2 #17874

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d0c6dc1
opcm: Update upgrade method for disputegame-v2
Inphi Oct 15, 2025
55a98a3
update opcm semver
Inphi Oct 15, 2025
30df97d
check game args; run post-upgrade checks
Inphi Oct 16, 2025
0488e9b
update std validator semver lock
Inphi Oct 16, 2025
860717a
fix assertGameArgsLength error prefix
Inphi Oct 16, 2025
02492ec
opcm and validator fixes
Inphi Oct 16, 2025
6d65ec4
lint LibGameArgs
Inphi Oct 16, 2025
1fa0605
fix interfaces; natspec
Inphi Oct 16, 2025
0d4f9fe
fix natspec in opcm
Inphi Oct 16, 2025
d4ae9af
forwards-compatible challenger/proposer retrieval
Inphi Oct 17, 2025
4142008
assert deployed CANNON game parameters
Inphi Oct 17, 2025
c869237
use v2 getters
Inphi Oct 17, 2025
ff2fa93
review comments
Inphi Oct 19, 2025
b45d83c
fix asr getter name
Inphi Oct 20, 2025
157c431
use v1 functions for existing upgrade path
Inphi Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/contracts-bedrock/interfaces/L1/IOPContractsManagerStandardValidator.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ interface IOPContractsManagerStandardValidator {
address challenger;
}

error InvalidGameArgsLength();
Comment thread
Inphi marked this conversation as resolved.

function version() external view returns (string memory);
function anchorStateRegistryImpl() external view returns (address);
function challenger() external view returns (address);
Expand Down
7 changes: 6 additions & 1 deletion packages/contracts-bedrock/snapshots/abi/OPContractsManagerStandardValidator.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@
"type": "string"
}
],
"stateMutability": "pure",
"stateMutability": "view",
"type": "function"
},
{
Expand Down Expand Up @@ -465,5 +465,10 @@
],
"stateMutability": "view",
"type": "function"
},
{
"inputs": [],
"name": "InvalidGameArgsLength",
"type": "error"
}
]
16 changes: 16 additions & 0 deletions packages/contracts-bedrock/snapshots/abi/OPContractsManagerUpgrader.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,22 @@
"name": "IdentityPrecompileCallFailed",
"type": "error"
},
{
"inputs": [
{
"internalType": "bytes32",
"name": "devFeature",
"type": "bytes32"
}
],
"name": "InvalidDevFeatureAccess",
Comment thread
Inphi marked this conversation as resolved.
"type": "error"
},
{
"inputs": [],
"name": "InvalidGameArgsLength",
"type": "error"
},
{
"inputs": [],
"name": "NotABlueprint",
Expand Down
8 changes: 4 additions & 4 deletions packages/contracts-bedrock/snapshots/semver-lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@
"sourceCodeHash": "0xfca613b5d055ffc4c3cbccb0773ddb9030abedc1aa6508c9e2e7727cc0cd617b"
},
"src/L1/OPContractsManager.sol:OPContractsManager": {
"initCodeHash": "0x4025118658a1c56c4fc2d0166081e6d27da980318e749e7811c7178115e4413e",
"sourceCodeHash": "0xdb243ac7475b0214b8f662aa04f696d9ff213dade6b1bdade379e84df419b75a"
"initCodeHash": "0xc6a5146f158bc14297447cda1668f83e8dbfdd74f1b8bc2291d9626933bd23ad",
"sourceCodeHash": "0x4df4f706ece6d6c521a2fe636b632ba06c6ecea160136ea47be9f80f60dc973c"
},
"src/L1/OPContractsManagerStandardValidator.sol:OPContractsManagerStandardValidator": {
"initCodeHash": "0x57d6a6729d887ead009d518e8f17fa0d26bfc97b8efe1494ab4ef8dbb000d109",
"sourceCodeHash": "0x1d58891954cf782d2fe4f112b0c7fd25be991c2b8873f10d8545c653b517cac9"
"initCodeHash": "0x2eaa345ba05582c67b40a1eb7ec9d54823aa08468e697e2d6c04bb74cc574abc",
"sourceCodeHash": "0x30d7e4243a3bab7fea8504be2cd24f2c5ab3335b802d62282a374a458a08feec"
},
"src/L1/OptimismPortal2.sol:OptimismPortal2": {
"initCodeHash": "0x5bf576ea7f566e402a997204988471fc9b971410aa9dff8fe810b10baf6b7456",
Expand Down
Loading