all: Update op-geth to use blobGasUsed field for DA footprint#17861
Merged
sebastianst merged 1 commit intodevelopfrom Oct 17, 2025
Merged
all: Update op-geth to use blobGasUsed field for DA footprint#17861sebastianst merged 1 commit intodevelopfrom
sebastianst merged 1 commit intodevelopfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #17861 +/- ##
============================================
- Coverage 81.15% 0 -81.16%
============================================
Files 119 0 -119
Lines 6320 0 -6320
============================================
- Hits 5129 0 -5129
+ Misses 1191 0 -1191
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
sebastianst
force-pushed
the
seb/da-footprint-use-blobGasUsed
branch
4 times, most recently
from
6056280 to
25e2d20
Compare
sebastianst
force-pushed
the
seb/da-footprint-use-blobGasUsed
branch
from
25e2d20 to
969265c
Compare
geoknee
reviewed
Oct 17, 2025
geoknee
approved these changes
Oct 17, 2025
Contributor
geoknee
left a comment
geoknee
left a comment
There was a problem hiding this comment.
Nice, I like the changes to the dsl.
sebastianst
force-pushed
the
seb/da-footprint-use-blobGasUsed
branch
2 times, most recently
from
3c121f6 to
9eb3cb1
Compare
sebastianst
force-pushed
the
seb/da-footprint-use-blobGasUsed
branch
from
9eb3cb1 to
8df75cb
Compare
ajsutton
pushed a commit
that referenced
this pull request
Oct 20, 2025
ClaytonNorthey92
added a commit
to hemilabs/optimism
that referenced
this pull request
Dec 1, 2025
* txmgr: allow blobs to be sent with fusaka-compatible cell proofs (sidecar version 1) by configuration (#17620)
* update batcher
* txmgr: log full tx hash to enable debugging
* cell proofs OFF by default
* thread configurable helper through to test code and add test TODOs
* wire up flag
* fix test
* op-e2e/actions: add EnableCellProofs config
* remove TODO
* use regular not atomic bool
* refactor MakeSidecar
* optimize creation of proofs slice
* feat: add rules for Diamond (#17640)
* contracts: Add new dispute game dev feature flags to bedrock test matrix (#17635)
* Integrate v2 dispute game feature flag into FeatureFlags setup util
* Add v2 flag to circleci matrix
* Add CANNON_KONA to test matrix
* fix: have acceptance job skip building contract tests (#17639)
Skips building contract tests in the acceptance job which reduces
the amount of memory used and decreases the chance of the job
being killed. Also makes it faster.
* op-e2e/actions: replicate geth txpool validation in `L1Miner.IncludeTx` (#17636)
* op-e2e/actions: replicate geth txpool validation in L1Miner.IncludeTx
* lint
* remove unecessary check
* op-node/rollup: remove ReceivedUnsafePayloadEvent event (#17530)
* op-node/rollup: remove ReceivedUnsafePayloadEvent event
* op-node/rollup: add lock around AddUnsafePayload
* op-deployer: setup forge callers for apply deploy scripts (#17637)
* op-deployer: prepare deploy scripts with forge invokers
* op-deployer: align test script with runWithBytes convention
* remove runWithBytes from DeployOPChain.s.sol
* op-e2e: Tweak EL Sync Test to check non genesis (#17440)
* fix(ai-contracts-test): handle 504 timeout, prevent duplicate work, prompt changes (#17616)
* fix(ai-contracts-test): handle 504 timeout and prevent duplicate work
- add 30s timeout and exponential backoff retry for Devin API server errors
- exclude files processed in last 7 days from ranking to avoid duplicate work
- add system version tracking to log entries
- minor cleanup: sort imports, remove shebangs and add invariants/ to exclusion list
- update runbook with latest changes
* fix(prompt): correct test naming, categorization, and assertion patterns
* update opcm.upgrade* natspec to explain the delegateCaller assumptions (#17644)
* update opcm.upgrade* natspec to explain the delegateCaller assumptions
* fix semver
* change semver
* feat: add ProtocolVersions to restrictions (#17651)
* feat: add ProtocolVersions to restrictions
* chore: snapshots
* sysgo: l1 geth subprocess support (#17619)
* refactor(test): standardize Unclassified to Uncategorized in test naming (#17650)
* refactor(test): standardize Unclassified to Uncategorized in test naming
- update test contract names from *_Unclassified_Test to *_Uncategorized_Test
- simplify checkTestMethodName function to only check for "Uncategorized"
- remove unused featureEnabledName parameter in checkTestMethodName
* Apply suggestion from @graphite-app[bot]
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* Apply suggestion from @JosepBove
Co-authored-by: JosepBove <josep@oplabs.co>
---------
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: JosepBove <josep@oplabs.co>
* feat(op-acceptance-tests): kurtosis nightly tests. (#17658)
* add valid semver check script and tests (#17641)
* add valid semver check script and tests
* upgrade MERC20F in opcm.upgrade
* cleanup
* cleanup
* change semver
* op-node: refactor EngineController (#17647)
* op-node/rollup: merge CLSync with EngineController
* op-node/rollup: migrate CLSync tests to EngineController
* op-node/rollup: use e.requestForkchoiceUpdate instead of emit
* op-node: renames
* op-node: lock unit test expectation
* op-node: better comments
* op-node: EngineController: Proper locking (#17648)
* op-node: EngineController: Proper locking
* op-node: EngineController: proper tryUpdateEngine sync
* stick to rwlock for simplicity
* Remove goroutine limit since race solved
* proper locking for ForceReset
* fix rebase
* fix locking
* op-deployer: ensure standard forge version matches mise (#17670)
* chore(op-acceptance-tests): ci; discord notifications. (#17672)
- Update Platforms notification from user 'stefano' to role 'protocol devx pod'
- Remove 'changwan' from Kurtosis notifications
* clean(op-acceptance-tests): ci; consolidate workflows. (#17673)
We no longer need a separate workfor for pre/post-merge to develop.
* all: update op-geth to "fusaka defence cherry pick" commit (#17661)
* updated op-geth to v1.101603.0-synctest.0.0.20250930110811-5eee1eab50e6
pairs with https://github.com/ethereum-optimism/op-geth/pull/690
* Updated op-geth to v1.101603.1-rc.1
* opcm: Add unit tests around DevFeatures (#17643)
* Add unit tests for DevFeatures.sol, fix logic
* Port changes and tests to go util
* Bump contract versions
* Run semver-lock
* Align test names with existing conventions
* ci: Add nightly heavy fuzz testing job (#17668)
* ci: Add nightly heavy fuzz testing job
- Add contracts-bedrock-heavy-fuzz-nightly job using ciheavy profile
- Configure for 20000 fuzz runs, 128 invariant runs, 512 depth
- Schedule via build_daily (nightly at 2 AM UTC)
- Add heavy_fuzz_dispatch parameter for manual testing
- Set 90m timeout for comprehensive fuzzing
* Update .circleci/config.yml
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* ci: Address PR feedback - remove unnecessary steps
- Remove 'Lint forge test names' step from nightly job
- Remove contracts-bedrock-build from workflow (job builds as needed)
- Update dependency to initialize directly
Addresses feedback from @mds1 and @aliersh
* ci: Restore duplicate generate-flaky-report section
Restores the duplicated generate-flaky-report job that was removed
during merge conflict resolution in b379b03. The duplicate section
was part of the develop branch changes and should not have been
removed as it was outside the scope of this PR.
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Ariel Diaz <65925295+aliersh@users.noreply.github.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* op-acceptance-tests: introduce flake-shake system (#17646)
Flake-shake is a test stability validation system that runs tests multiple times to detect flakiness before they reach production gates.
It serves as a quarantine area where new or potentially unstable tests must prove their reliability.
* op-node: merge EngineResetDeriver with EngineController (#17662)
* op-node: merge EngineResetDeriver with EngineController
* op-node/rollup: move startPayload under EngineController
* op-acceptance-tests: Cache and canonicalize L2EL payloads after gap fill (#17675)
* op-acceptance-tests: Cache and canonicalize L2EL payloads after gap fill
* Clarify args for retrying
* better var name
* op-contracts: DeployOPChain.s.sol conform to input/output struct pattern (#17657)
* op-contracts: DeployOPChain.s.sol conform to input/output struct pattern
* op-contracts: remove unused imports
* op-contracts: fix build check findings
* ChainAssertions.sol: add logs
* L2ChainDeployment: revert field name, json tag change
* DeployOPChain.s.sol: add input validations for dispute params
* Replace go-bip39 dependency (#17526)
* Replace go-bip39 dependency
* Bump go-ethereum-hdwallet dep
* op-node,op-program,kona: embed L1ChainConfig in configuration (#17568)
* op-node: add optional flag to load L1ChainConfig
And wire up to BlockInfo.BlobBaseFee() getter, which now accepts the config.
Flag need not be provided as long as the chain has a known l1 chain id (Mainnet, Sepolia).
* use test l1 chain config in many tests
* more wiring
* WIP: get op-program to compile
I don't expect this to work, yet
* sysgo: wire up op-node constructor with L1ChainConfig
* op-program host wiring
* op-e2e/actions wiring
* wire up boot info
* op-program looks up chain config for l1 mainnet and l1 sepolia
* wire up l1 chain config in op-e2e/system
* fix tests by passing sepolia chan config from op-geth
* add L1ChainConfig to e2esys.System struct
* handle err
* op-program/interop fixes
* add l1ChainConfig to supersystem_l2.go
* op-program: wire up l1chainconfigs to host flags and config
* fix mockInteropBootstrapOracle
* feat(l1): add custom l1 configs to kona proof
* op-program/chaincfg: split loading of l1 and l2 chain configs
* op-program/boot-interop: us a single l1 chain config
* fix tests
* lint
* wiring in op-challenger
* expose L1Genesis on SuperDisputeSystem
* lint
* fix test
* fixes
* add case to switch statement
* fix op-challenger error handling
* op-program: one chain config for interop, multiple otherwise
* op-program/host: always return a single l1 chain config
* fix chain Id comparisons
also add error for nil blob schedule
* op-node/service: add unit tests for NewL1ChainConfig
* op-program/host: use a single L1ChainConfig
* op-program can fallback to mainnet / sepolia L1s automatically
* lint
* add check
* sysgo/l2_Cl_opnode: replicate op-node fallback to known l1 chain configs
* single l1 genesis in challenger and vm executor
* simplify
* typo
* more harmony around single l1 chain config
* tweaks
* remove whoopsie
* wire up l1ChainConfig in test sequencer
* deprecate calcBlobFeeDefault
* reinstate method
* lint
* feat(devstack/kona): fix devstack commands for kona
* Add TestCannonNetworkorL1GenesisPathRequired and TestAsteriscNetworkorL1GenesisPathRequired
* move --l1-config-path into required args slice
* use single l1ChainConfig in RunKonaNative
* remove caldBlobFeeDefault
* refactor tests with validConfigWithNoNetworks
* NewL1ChainConfig warns when config is ignored
* add assertion for --l1-config-path in TestKonaFillHostCommand
* Implement validation for L1GenesisPath in OracleCommand and update tests to reflect changes
* fail on multiple l1 networks
* move lookup of l1 chain config out of core sysgo constructors and into system_synctester_ext.go
* remove duplicate test
* op-program/chaincfg: checkConfigFilenames permits 0 or 1 l1 genesis files
Adds test for not supplying a custom l1 genesis config.
* add test case for multiple l1 genesis files
* op-program/boot-info: add test for missing l1 chain config
* op-program/client/boot: panic if custom chain l1 config does not match rollup config l1 chain id
* specify l1/l2 in err msg
* typo
* fix test
* use single l1 chain config in interop_test.go
* validate l1 chain id matches when loading config from file
* reorder arguments for derive.L1InfoDeposit
* reorder action helper verifier/sequencer constructor arguments
* add comment
* reordering
* assert chain is consistency
* reorder
* change to path flag
* dedupe and fix test
* remove magic code from WithKonaNode sysgo helper
* DRY out, centralize, dedupe and unit test L1ChainConfigByChainID
* undo ff0901783842e80c76c50510117d87447f8223a4
* Update op-devstack/sysgo/l2_challenger.go
Co-authored-by: mbaxter <meredith@oplabs.co>
* fix
* mockInteropBootstrapOracle embeds a single l1ChainCfg and tests assert
* challenger should not require l1 genesis path to be configured
* make l1 genesis config optional for kona
* allow for multiple l1 configs in custom chain fs
* add l1 genesis flag to op-challenger
* fix
* fix lints and tests
* fix op-program config tests
* fix op-program cmd tests
* remove failing tests that shouldnt exist
* add comment
* Add TestCalcBlobFeeAcrossForksWithFixedExcess
* improve test
it will now fail if any fork is rescheduled
* fix test
* fix system/proofs tests
* Add warning to CalcBlobFeeCancun
* lint
---------
Co-authored-by: theochap <theodore.chap@gmail.com>
Co-authored-by: mbaxter <meredith@oplabs.co>
Co-authored-by: Josh Klopfenstein <joshklop@oplabs.co>
* Run isolated cannon-kona devfeature in ci (#17702)
* op-e2e/actions: add L1 Osaka activation test (#17666)
* add Fusaka activation test
* updated the test to add L1 blob base fee assertions
* fixes
* wire up Fusaka on L1 and improve test
* give test teeth
* improve prague fork test
* activate prague at genesis and osaka after
* updated op-geth to v1.101603.0-synctest.0.0.20250930110811-5eee1eab50e6
pairs with https://github.com/ethereum-optimism/op-geth/pull/690
* extend test to cover BPO forks
* typo fix
* typo fix
* dedupe tests
* rename file
* respond to review
---------
Co-authored-by: Dense <DenseDenise12@proton.me>
* feat(test-validation): add library support (#17690)
* feat(test-validation): add library support
- extract functions from AST for libraries (internal functions not in ABI)
- add test coverage for library validation helpers
- update exclusions for library-specific test patterns
- add success message when all validations pass
* fix(test): fix DevFeatures test contract naming
* test(op-program): test resolution of l1 chain config by chain ID (#17707)
* test resolution of l1 chain config by chain ID in op-program
* add sanity check
* fix(op-acceptance-tests): flaky tests report. (#17706)
Ensure we only show tests for the target branch
* op-acceptance-tests: Fix Unsafe payload queue syncing logic comments (#17712)
* fix(test) exclude foundry VM address from L2ToL2CrossDomainMessenger fuzz test (#17709)
* op-deployer: reduce default GasPadFactor 2.0 -> 1.2 (#17710)
* op-acceptance-tests: test that unsafe chain is stalled when ReqResSync is disabled (#17696)
* op-acceptance-tests: test that unsafe chain is stalled when ReqResSync is disabled
* address comments
* Full TimelockGuard implementation (#17584)
* feat: implement configureTimelockGuard function
- Add configureTimelockGuard function to allow Safes to set timelock delays
- Validate timelock delay between 1 second and 1 year
- Check that guard is properly enabled on calling Safe using getStorageAt()
- Store configuration per Safe with GuardConfigured event emission
- Add comprehensive test suite covering all spec requirements
- Implement IGuard interface for Safe compatibility
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* feat: implement clearTimelockGuard function
- Add clearTimelockGuard function to allow Safes to clear timelock configuration
- Validate that guard is disabled before allowing configuration clearing
- Check that Safe was previously configured before clearing
- Delete configuration data and emit GuardCleared event
- Add comprehensive test suite covering all spec requirements
- Add new errors: TimelockGuard_GuardNotConfigured, TimelockGuard_GuardStillEnabled
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* refactor: extract guard checking logic to internal helper function
- Add internal _getGuard() helper to centralize guard address retrieval
- Update configureTimelockGuard and clearTimelockGuard to use helper
- Reduces code duplication and improves maintainability
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* feat: implement cancellationThreshold function
- Add cancellationThreshold function to return current threshold for a Safe
- Return 0 if guard not enabled or not configured
- Initialize to 1 when Safe configures guard
- Clear threshold when Safe clears guard configuration
- Add comprehensive test suite covering all spec requirements
- Function never reverts as per spec requirements
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* feat: add placeholder functions for remaining TimelockGuard functionality
- Add scheduleTransaction placeholder (Function 4)
- Add checkPendingTransactions placeholder (Function 6)
- Add rejectTransaction placeholder (Function 7)
- Add rejectTransactionWithSignature placeholder (Function 8)
- Add cancelTransaction placeholder (Function 9)
- Update checkTransaction placeholder (Function 5)
- All placeholders have proper signatures and documentation
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
* Self review fixes
* Fix warnings on unimplemented functions
* Fix names of test functions
* Satisfy semgrep by removing revert with string
* Remove arg names from unimplemented functions
* Snapshots
* Add interface
* Simplify cancellationThreshold() getter
* Replace _getGuard with isGuardEnabled
* Allow a timelock delay of zero
* TimelockGuard: Add scheduleTransaction()
* Add todo note
* Pseudocode draft of a non-nested timelock
Simpler code
Add cancelTransaction function relying on the Safe's internal logic
undo type change
Add note explaining getScheduledTransactions
* Remove signatures field from ExecTransactionParams
* Refactor tests with improve utils (_getDummyTx, _getSignaturesForTx)
* Test for TransactionCancelled event
* Further improve util functions
* Add approve hash test case
* fix warnings
* Use correct typing for Safe addresses
This is applied to function inputs/outputs as well as mappings and
events
* Add additional scheduleTransaction tests
* Enable specifying which safeInstance in utility functions
* Change cancelTransaction to accept a tx hash
* Add increaseCancellationThreshold to cancelTransaction
* Add configured boolean to guard config
* Fix signature reuse vulnerability in cancelTransaction
Include transaction hash in cancellation signature data to prevent
signatures from being reused across different transactions with the
same nonce. Updates both contract implementation and tests.
* Move signature verification before existence check in scheduleTransaction
* Remove unused console.logs
* Fix increaseCancellationThreshold inputs
* Separate cancellation threshold events from transaction cancellation
Add CancellationThresholdUpdated event and emit it from threshold
modification functions. Remove threshold parameter from TransactionCancelled
event for cleaner separation of concerns.
* Remove unused _txHash argument from resetCancellation function
* Update ITimelockGuard to match implementation
* Use configured flag instead of timelockDelay check in clearTimelockGuard
* Add configuration check to scheduleTransaction and fix test names
* Implement checkTransaction
* Add itest placeholder contract
* Add comment to checkAfterExecution body
* pre-pr checks
* Remove GuardConfig.configured boolean field
We can simply use `timelock > 0` as an indicator of configuration
* Remove clearTimelockGuard
The right way to do this is now just to set timelockDelay to zero.
* Refactor: Add TransactionBuilder library
This library significantly reduces the amount of boilerplace required to
setup a Safe transaction, then schedule, cancel, or execute it.
* Add unreachable AlreadyExecuted error
* Add integration tests
* Add getPendingTransactions function and tests
* Add tests for getScheduledTransaction
* Add _ prefix in front of internal mappings
* Rename viewTimelockGuard to timelockSafeConfigurationper specs
* Add maxCancellationThreshold
* Improve names on getter functions
* Remove @dev tags with invariants
Avoids duplicating logic between specs and implementation
* Update configureTimelockGuard to accept and validate signatures outside of the Safe
* Refactor: use a single struct to store all state for a given Safe
* Do not unnecessarily reset cancellation threshold when config set to 0
* Revert "Update configureTimelockGuard to accept and validate signatures outside of the Safe"
This reverts commit daad53b9090af05de64177680dfbe9baf7b2f9e8.
* Move timelockDelay out of unnecessary struct
* Add top level detail natspec, reorder functions by vis and mutability
* Remove test that does not conform to spec
* Add cancelTransactionOnSafe to interface as reverting function
* Add many more comments
* Apply suggestions from code review
Co-authored-by: Alberto Cuesta Cañada <38806121+alcueca@users.noreply.github.com>
* Fix ITimelockGuard iface to match impl
* Rename arguments for consistency
* Add/fixup @param on events
* Small fixes
* Fix ITimelockGuard declaration
* Improve names on getter functions
* Move ExecTransactionParams into TimelockGuard.sol
* Address comment nits
* Add TimelockGuard_MaxCancellationThreshold_Test and _deploySafe helper
* Fix up iface and comment typos
* Fix storage lookup in test
* Add enum Transaction state and remove cancelled/executed booleans
* add /// @custom:field on ScheduledTransaction struct
* add /// @custom:field on ExecTransactionParams struct
* Add SemverComp to enforce minimum Safe version
* Rename empty function to signCancellationForSafe
* Fix location of external view functions
* Add some more comments where helpful.
* Further expand on the maxCancellationThreshold rationale
* Clarify blocking threshold
* iFace fixes
* Fix iface
* Move update of tx state, event emission and cancellationThreshold into checkAfterExection
* Simplified comment
* remove unclear comments
* fix semgrep sol-style-use-abi-encodecall
* snapshots
* Add course of actions table
* Remove unnecessary address arg from signCancellation
* Fix test names
* Fix test name validation
* Remove enabled guard check from configureTimelockGuard
* Allow <ContractName>_Integration_Test in tests
* Add isExcludedTest in checkContractNameFilePath()
* Update semver-lock
* Fix typo
* fix typo in tests
---------
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: alcueca <alberto@yield.is>
Co-authored-by: Alberto Cuesta Cañada <38806121+alcueca@users.noreply.github.com>
* opcm: Support cannon+kona games in updatePrestates (#17512)
* opcm: Support cannon+kona games in updatePrestates
* fmt; and check devfeatures flag at updatePrestate
* update semver and snapshots
* remove duplicate import
* bump semver after rebase
* fix addGameType for SUPER_CANNON_KONA; add more cannon-kona tests
* remove proxyAdmin from UpdatePrestateInput
* update IOPCM interface
* update semver
* check all topics in expectEmit
* add updatePrestate helper function for testing
* lint test
* fix semgrep issues
---------
Co-authored-by: inphi <mlaw2501@gmail.com>
* op-service/L1BeaconClient: allow blob proof verification to be skipped via `l1.beacon.skip-blob-verification` flag (#17713)
* op-service/L1BeaconClient: allow blob proof verification to be skipped via CLI flag
* assign parameter correctly
* add test at the L1BeaconClient level
* move skip boolean into existing config struct
* tweak flag description
* Add `skip-blob-verification` flag to op-program and op-challenger (#17718)
* op-program: Add skip-blob-verification flag
* op-challenger: add flag to skip blob verification
* Soften warning message for skip blob verification
* feat(op-conductor): rollup-boost partial unhealthiness tolerance (#17633)
* feat(op-conductor): rollup-boost partial unhealthiness tolerance
Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co>
* rlock protection to currentValue function
Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co>
* timeboundcounter separate file and unit tests
Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co>
* comment about the concurrent access bad path testing
Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co>
* nit
Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co>
* shift the max value logic to health monitor
Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co>
* nit
Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co>
---------
Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co>
* l1-beacon-client: verify blobs using commitment only (not the proof) (#17725)
* recompute blob proof if skipBlobVerification
* use even simpler verification
* replace verification logic
* refactor to make verification more direct
This approach does not use any additional data from the beacon endpoint, aside from the blob itself, so anticipates future API changes where this will be the only data provided.
* tweak comments
* rename to verifyBlob
* tweak test comments
* Revert "op-service/L1BeaconClient: allow blob proof verification to be skipped via `l1.beacon.skip-blob-verification` flag (#17713)"
This reverts commit 05ba528ae52a48efc2cde8e0e0390cf47ad5f4ad.
* Revert "Add `skip-blob-verification` flag to op-program and op-challenger (#17718)"
This reverts commit 3ee883bcfb1b6ac4717ae430a84e92d08359c21f.
* add an extra unit test
* sysgo: add Osaka activation test (#17529)
* op-service/txplan: support blob txs
* op-service/txinclude: handle future nonce gaps
This can happen when we get mempool errors like "nonce too high", which
itself can occur when we hit "account limit exceeded" errors in the blob
pool.
* sysgo: add Osaka activation test
* sysext: infer L1 config when possible
* op-challenger: Convert l1-genesis flag to a vm flag (#17722)
* op-challenger: convert l1 genesis flag to VMFlag
* Disallow l1-genesis flag use with the network flag
* typo
* another typo
---------
Co-authored-by: geoknee <georgeknee@googlemail.com>
* op-devstack: L2EL Engine API support for op-geth (#17714)
* op-service: Engine APIs
* op-devstack: L2EL Engine API support: op-geth
* Handle Read Only ELs
* Move to different dir
* op-devstack: DSL for ref by hash and FCU
* op-acceptance-tests: Manual Verifier Sync
* op-acceptance-tests: Manual Verifier Sync: Harden
* op-devstack: godoc and better var naming
* Remove upgrade controller from OPCM (#17660)
* upgrade controller removed from OPCM
* renamed upgradeController to l1PAO in DeployImplementations.Input
* Update semver
* Remove upgradeController from the docs
* Fix VerifyOPCM
* Did quite the find and replace here
* The OPCM constructor only takes 24 slots now
* Some straggler renamings
* Fix: semver-lock
* Doh
* Snapshots?
* lint
* Fixed the last of the lint with the power of regex
* fixed linting
* L1PAO == SuperchainProxyAdminOwner
* We shouldn't need to pass the upgrade controller to op-deployer to deploy opcm anymore
* L1PAO != SuperchainPAO
* Let's accept both the backwards compatible UPGRADE_CONTROLLER and the new L!_PROXY_ADMIN_OWNER
* Maybe I'll need to drop UPGRADE_CONTROLLER
* addressed comments from @bitwiseguy
* Needed the three dots, it seems
* Shortened form of L1PAO not used in code anymore
* update semver-lock and opcm bytecode
* *sigh*
* feat(ci): add manual workflow for AI contracts test maintenance system (#17730)
* build(ci): add manual workflow for AI contracts test maintenance system
- add ai_contracts_test_dispatch parameter for manual pipeline triggering
- add ai-contracts-test job that runs just ai-contracts-test command
- add ai-contracts-test-workflow with manual dispatch only
- use devin-api context for Devin API credentials
- set 60 minute timeout for AI contract test execution
* build(ci): store log artifact in AI contracts test workflow
- add store_artifacts step to save log.jsonl from test runs
* fix: handle socket timeouts in devin API client
- add TimeoutError exception handling in _make_request function
- update version to 0.3.2
* docs(ci): add runbook reference to AI contracts test job
* chore(op-acceptance-tests): op-acceptor v3.5.0 (#17739)
* Fix cli arg typo in op-challenger executor for op-program server (#17737)
* feat(op-acceptance-tests): flake-shake auto-promotions (#17692)
Adds semi-automated promotions to our FlakeShake system, by:
- Reviewing the flake-shake results for promotion candidates
- Creating a PR for the promotion-ready tests
- Notifying us of this on Slack
* beacon client: use new fusaka endpoint to get blobs (#17736)
* beacon client: use new fusaka endpoint to get blobs
Fallback to old endpoint on error.
* unexport method
* tests: rename clientWithValidation -> client
* remove comments
* Update op-service/sources/l1_beacon_client.go
---------
Co-authored-by: geoknee <georgeknee@googlemail.com>
* op-acceptance-tests: ELP2P for EL Syncing for unsafe gap (#17752)
* op-devstack: engine: FCU retry helper
* op-devstack: Helper for L2EL p2p removal
* op-acceptance-tests: ELP2P for EL Syncing for unsafe gap
* op-acceptance-tests: ELP2P newPayload not retained automatically
* op-acceptance-tests: Better comments
* Add file hashes to the u16a audit report (#17753)
* cleanup(ctb): Remove unused MT_CANNON env (#17731)
* opcm: Switch cannon kona tests to depend on dev features being set through env vars. (#17746)
Previously, the enabled case was tested by explicitly enabling the dev flag but CI has been updated to run all tests with and without the flag enabled.
The explicit enabling gets in the way of testing creator pattern changes.
* refactor(test): improve ProtocolVersions test coverage (#17721)
- add test for version constant
- ensure comprehensive coverage of all public elements
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* Add make gen-binding (#17761)
Adds a new make gen-binding command for generating or updating go
bindings for a contract.
Also includes documentation in the op-e2e README.
* op-deployer: Do not create cache directory on import (#17776)
* op-deployer: Do not create cache directory on import
* create the one the flag makes
* op-acceptance-tests: Add smoke tests for disputegamev2 (#17775)
* op-acceptance-tests: Add smoke tests for disputegamev2
* add missing skip
* op-service: use correct response type in blob retrieval (#17779)
* op-program/host: have prefetcher use new beacon API (not `blob_sidecars`) (#17778)
* remove GetBlobSidecars from L1BlobSource
* remove tests
* tweak comments
* fix test
* feat(op-acceptance-tests): flake-shake; tweaks (#17780)
* fix(op-acceptance-tests): flake-shake; job URL.
Make the job URL in our Slack notification point to the artifacts tab of the report job URL.
* fix(op-acceptance-tests): flake-shake; add job URL to PR body.
* fix(op-acceptance-tests): flake-shake; report owner.
* fix(op-acceptance-tests): flake-shake; tweaked defaults.
* fix(circleci): always run contracts-bedrock-build before docker-build (#17781)
* fix(circleci): always run contracts-bedrock-build before docker-build
* fix(circleci): include op-deployer in scheduled-docker-publish
* Interfaced CLI Context (#17759)
* op-node: Initialization Control Refactor (#17766)
* Interfaced CLI Context
* No more side-effect initialization
* Wire L1 and Server Overrides to Initialization
* add permissable side-effects and mark with comments
* Address Adrian's Comments
* vm-runner: Annotate logs with a trace id for runs (#17801)
* op-deployer: add cli-level bootstrap integration tests (#17803)
* tests: Re-enable Interop Proof Acceptance Tests (#17770)
* Re-enable Interop Proof Acceptance Tests
* Flake Shake
* chore(op-acceptance-tests): flake-shake; test promotions (#17804)
* feat(ai-eng): release v1.0.0 production-Ready Contracts Test Maintenance System (#17807)
* refactor(ai-contracts-test): use CircleCI artifacts for test exclusion
- replace log.jsonl with log.json and fetch via CircleCI API
- add circleci-api-token context for artifact access
- treat blocked status as success when PR exists
- remove .env loading for CI-only execution
- improve Devin setup logging to single message
* fix(ai-eng): handle server errors and user-stopped sessions in devin client
- handle 502 Bad Gateway errors as retryable (like 504)
- add support for suspend_requested status when user stops session
- fix AttributeError when status is None during blocked check
- reduce resource_class from xlarge to large
* fix(ai-eng): improve devin session monitoring and reduce noise
- reduce timeout messages
- remove "finished" status handling
- clarify blocked status messages
- handle expired status separately
- reduce resource class from large to medium
* fix(ai-eng): add debug logging and fix artifact parsing in test exclusion
- add debug prints to trace CircleCI artifact fetching
- fix artifact parsing: use selected_files.test_path instead of test_path
* refactor(ai-contracts-test): integrate CircleCI API v2 for artifact-based test exclusion
- implement CircleCI API v2 to fetch artifacts from previous runs
- exclude test files processed in the last 2 weeks
- extract helper functions following SRP
- add debug logging for artifact fetching process
* fix(ai-contracts-test): prevent crash when manually stopping devin sessions
* chore(ai-contracts-test): release v1.0.0 with scheduled execution
- add bi-weekly monday-thursday scheduled workflow trigger in CircleCI
- update default branch from feature to develop for production use
- enhance prompt guidance for test organization and source order matching
* feat(op-acceptance-tests): flake-shake; fixes and improvements (#17811)
* fix(op-acceptance-tests): flake-shake; artifacts URL.
* fix(op-acceptance-tests): flake-shake; test URL.
* fix(op-acceptance-tests): flake-shake; close old/stale PRs.
* fix(op-acceptance-tests): flake-shake; updated flake-shake gate.
* fix(op-acceptance-tests): flake-shake; upload logs.
* fix(op-acceptance-tests): flake-shake; convert JSON logs to plaintext.
* fix(op-acceptance-tests): flake-shake; use CircleCI static egress IPs.
* clean(op-acceptance-tests): flake-shake; removed dummy test.
* op-node: allow for L2 chain configs to be passed to NewL1ChainConfig (#17799)
* do not error if l1 chain config has no BlobScheduleConfig, if it is an optimism config
* op-node: allow for L2 chain configs to be passed to NewL1ChainConfig
This should fix the problem where L3 nodes cannot start.
Closes https://github.com/ethereum-optimism/optimism/issues/17798
* typos
* op-devstack: Error handle when direct FCU call errored (#17816)
* op-acceptance-tests: Error handle when direct FCU call errored
* op-devstack: Track target node when Engine API invoked
* Add SaferSafes as child of the module and guard (#17767)
* Add SaferSafes as child of the module and guard
* Add ISaferSafes
* Test comment and assertion fixes
* Improve comments
* Make LivenessModule2 and TimelockGuard abstract
Move semver to SaferSafes
semver lock
* fix test contract name
* txmgr: replace `UseCellProofs` flag with `CellProofTime` flag (#17649)
* txmgr: replace UseCellProofs flag with CellProofTime flag
Closes https://github.com/ethereum-optimism/optimism/issues/17634
* use default CellProofTime in op-e2e/utils.NewTxMgrConfig
* fix comparison
* unit test the important bit
* WIP
* Apply suggestions from code review
Co-authored-by: Sebastian Stammler <seb@oplabs.co>
* Revert "WIP"
This reverts commit 1eb8a919576668dd2f124f051bc9bb866d63ba00.
* improve handling of fallback to cover 4 L1 chains
* fix test
* add debug log
* format
* add 12s buffer
* avoid overflow
---------
Co-authored-by: Sebastian Stammler <seb@oplabs.co>
* acceptance-tests: force batcher to use cell proofs in osaka test (#17818)
* op-{sync-tester|devstack}: Support multiple EL Sync Runs (#17800)
* op-{sync-tester|devstack} Support multiple EL Sync Runs
* op-acceptance-tests: Increase Unsafe payload signaling for window policy
* op-sync-tester: Async Set Canonical When EL Sync done
* op-devstack: Enable Engine API for SyncTesterEL
* op-acceptance-tests: Multiple EL Sync Runs for SyncTesterEL
* op-sync-tester: Reorganize Default EL Sync Policy
* op-sync-tester: ELSyncPolicy godoc and better initialization
* op-sync-tester: WindowSyncPolicy unit tests
* op-acceptance-tests: Comment for EL Sync Policy
* docs(ai-eng): update documentation for contract test maintenance system (#17820)
* docs(ai-eng): document contract test maintenance system
- add ai-eng and contracts-test-maintenance READMEs
- add comprehensive operational runbook (601 lines)
- cross-reference Notion docs (design doc, tech spec)
* docs(ai-eng): remove external notion documentation references
* docs(ai-eng): improve documentation clarity and add direct links
* docs(ai-eng): update graphite status to active
* fix(op-acceptance-tests): flake-shake; fix ci. (#17823)
* fix(circleci): ensure contracts-bedrock-build runs in release workflow (#17822)
* op-dispute-mon: distinguish 404 from output root not found (#17819)
* op-deployer: fix, support, test upgrades up to v4.1.0 (#17824)
* op-deployer: add upgrade v4_1_0 command (#17790)
* update superchain-registry/validation import
* op-deployer: fix upgrader.ArtifactsURL and add tests
* op-service: add WithForkBlock opt to anvil
* op-deployer: add cli level upgrade tests
* fix(op-acceptance-tests): flake-shake; misc. fixes (#17830)
* chore(op-acceptance-tests): flake-shake; TestL2ELP2PCanonicalChainAdvancedByFCU (#17833)
Run the new test 'TestL2ELP2PCanonicalChainAdvancedByFCU' through FlakeShake.
* chore(op-acceptance-tests): flake-shake; resource class (#17847)
* chore(op-acceptance-tests): flake-shake; tweaked default workers. (#17850)
This should reduce the chance of CircleCI timeouts.
* fix(ai-contracts-test): always fetch develop branch for artifact exclusions (#17840)
- hardcode branch to "develop" to avoid CIRCLE_BRANCH env var issues
* all: Add DA footprint configurability via SystemConfig (#17466)
Co-authored-by: Sebastian Stammler <seb@oplabs.co>
Co-authored-by: Matt Solomon <msolomon@oplabs.co>
* opcm: Update OPCM.deploy to use v2 games (#17408)
* feat: integrate v2 implementations into opcm
* fix: skip v2 implementations if not deployed
* chore: bump semver version
* feat: conditionally set the v2 games based on feature flag
* feat: add override for setup to re-deploy opcm with feature flag
* test: improve test by deploying with the feature flag and asserting on output
* test: add assertion that the deployment configuration on the dgf is correct
* chore: improve test name
* refactor: add helper function for feature toggled deployment of opcm
* fix: bytecode size check failing
* chore: run forge fmt
* fix: address CI naming and semver bump
* fix: rename setup contract name to align with ci checks
* chore: comment out added fix
* fix: verify opcm
* fix: naming convention for test contracts
* fix: move the updates for addGameType to the addGameType pr
* fix: proposer removed
* fix: rename function for clarity in VerifyOPCM script
Rename _isV2Implementation to _isV2DisputeGameImplementation for better clarity about what types of contracts this function checks for.
* fix: add proper gameArgs for V2 dispute game registration and fix setting output implementation on outupt struct
* test: add helper functin for creating game proxies
* test: refactor helper functions for test and remove impl from output struct
* test: test args correct on created proxy games
* chore: remove unused helper for now
* fix: remove guard clause from local issue
* chore: bump semver
* chore: revert changes to ignore v2 implementations
* fix: check bitmap and contract name for ref
* test: with feature toggle on
* chore: forge fmt
* Revert "chore: forge fmt"
This reverts commit d029fdb8dd12445a839026972e3859be7aae1470.
* Revert "test: with feature toggle on"
This reverts commit a932eb608d25f9acf486ce49aeb5318742c666de.
* chore: forge fmt
* fix: test compiler restriction fix
* Revert "fix: test compiler restriction fix"
This reverts commit 50282cf4fbf32b2a3615a4d9537e0887436f682d.
* fix: compiler bump
* fix: typo
* test: add test for verify opcm with v2 dispute games deployed
* test: add skips for v1 tests if v2 deployed
* fix: skip standard validator until its implemented
* fix: skip addGameType until its implemented
* fix: skip updatePrestate until its implemented
* fix: remove diff in natspec
* chore: add TODO comments with issue tracking to skips
* fix: bump semver
* chore: bump semver
* Fix silent merge conflicts with develop
* Bump semver version
* Run semver-lock
* Reintroduce OPContractsManager_Version_Test
* Cleanup - revert comment change
* Remove v2 contracts from DeployOutput
* Remove unused imports
* Update DeployOPChain tests to run across feature flags (in progress)
* Update OPCM tests to work with FeatureFlags options
* Merge PermissionedDisputeGame tests, use feature flags
* Merge FaultDisputeGame tests, use feature flag in setup
* Remove redundant test
* Fix test name
* Fix anchorRootNotFound test - pass in extra data
* Extend deployment test to check more fields
* Add guards around new setImplementation call
* Add new error to OPCM interface
* Run semver-lock
* Prefix var with underscore
* Remove unused imports
* Regenerate snapshots
* Pass opcm as an argument to _verifyOpcmContractRef
* Reorganize verifyOPCM v2 skip logic
* Add TODO to fix acceptance test
* Add function documentation for the new opcm param
* Cleanup: add test assertion messages
* Remove opcm param from runSingle script
* Tweak method documentation
* Cleanup dead code
---------
Co-authored-by: mbaxter <meredith@oplabs.co>
* feat(op-acceptance-tests): moved notifications to Slack (#17843)
* chore(op-acceptance-tests): op-acceptor v3.6.0 (#17842)
Updates op-acceptor to [v.3.6.0](https://github.com/ethereum-optimism/infra/releases/tag/op-acceptor%2Fv3.6.0).
* op-acceptance-tests: Integration test for op-deployer add-game-type (#17865)
* op-acceptance-tests: Integration test for op-deployer add-game-type
* more generic gameType adder fn in devstack
* chore(op-acceptance-tests): flake-shake; test promotions (#17851)
Co-authored-by: Stefano Charissis <stefano@oplabs.co>
* make solidity upgrade test run for base ink and unichain, update fork block and remove running of U16A upgrade (#17827)
* make solidity upgrade test run for base ink and unichain, update fork block and remove running of U16A upgrade
* fixes
* op-supernode: Initial Chain Container Framework (#17659)
* op-supernode: Initial Chain Container Framework
* op-supernode: Shared L1
* Context Exit Cleanup
* op-supernode: RPC Router Resource for Virtual Nodes
* op-supernode: Virutal Node Lifecycle Fixes
* op-supernode: Node and Chain Lifecycle Updates ; Unit Tests
* just coverage
* op-supernode minor 2-chain runtime fixes
* op-supernode: Single Chain TestCLAdvance for Supernode
* op-acceptance-tests: 2 L2 System ; Supernode Multi-Tenant-CL Test
* remove e2e changes
* README
* Restructure Packages/Files
* Rename Proxy to Router ; Rewrite Acceptance Tests
* update to new op-node InitializationOverrides struct
* Update to CLI Interface ; Related/Required Edits
* Shared Metrics
* Repair Acceptance Tests ; Register optimism handler for supernode
* Flake Shake ; Remove Sample Flag
* Delete unused preset
* Remove Sample from Tests
* Fix chain_container_test signatures
* lint
* remove unused
* Review Comments
* Use eth.ChainID
* Use OP Service HTTP Server
* remove unused superchainProxyAdmin immutable variable from OPCM (#17828)
* remove unused protocolVersions and superchainProxyAdmin immutable variables
* keep protocolVersions
* fixes
* refactor(test): improve ResourceMetering test coverage and quality (#17812)
* refactor(test): improve ResourceMetering test coverage and quality
- convert 3 duplicate empty block tests to single fuzz test
- add test for block.basefee = 0 protection
- add test for below-target gas usage (fee decrease)
- add test for minimum base fee configuration
- reorganize test contracts to match source declaration order
* test: add explicit assertion for base fee protection in zero basefee test
- Add assertGt(prevBaseFee, 0) to verify Math.max protection works
- Addresses automated PR review feedback
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* feat(ai-contracts-test): add Slack notifications and bug fixes (v1.1.0) (#17876)
* feat(ai-contracts-test): add Slack notification for PR creation
* fix(ai-contracts-test): add pagination to fetch enough pipelines
- paginate through CircleCI API to fetch up to 200 pipelines
- add debug logging to troubleshoot artifact exclusion
- temporarily exclude ReinitializableBase
* fix(ai-contracts-test): exit with error when devin session blocked without PR
* fix(ai-contracts-test): use Slack orb pattern for PR notifications
* fix(ai-contracts-test): fix user tag formar in slack message
* docs(ai-contracts-test): enhance prompt with constructor and assertion guidelines
- Add zero tolerance rule for constructor parameter test organization
- Add TargetContract_Constructor_Test naming pattern for constructor tests
- Require explicit assertions beyond non-reversion checks
- Add examples for proper assertion usage and constructor test structure
- Fix typo in avoid section ("contex" → "context")
* docs(ai-contracts-test): update documentation for v1.1.0 release
* Update ops/ai-eng/contracts-test-maintenance/prompt/prompt.md
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* Update ops/ai-eng/contracts-test-maintenance/prompt/prompt.md
Co-authored-by: smartcontracts <14298799+smartcontracts@users.noreply.github.com>
* chore(ai-contracts-test): remove ReinitializableBase test file from exclusion list
---------
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: smartcontracts <14298799+smartcontracts@users.noreply.github.com>
* feat: reduce lite profile fuzz runs (#17877)
Reduces lite profile fuzz and invariant runs to 8 across the board.
We now run heavier fuzz runs in CI, so it's generally nicer and
easier if we run significantly reduced runs locally.
* fix(acceptance-tests/op-reth): fix acceptance tests for op-reth (#17882)
* op-dispute-mon: Consider node invalid if it has not processed L1 past the game head (#17831)
* Update TODO with more granular issue number (#17885)
* refactor(test): improve ReinitializableBase test organization (#17839)
* refactor(test): improve ReinitializableBase test organization
- Split tests into separate contracts per function
- ReinitializableBase_Constructor_Test for constructor validation
- ReinitializableBase_InitVersion_Test for initVersion getter
- Fixed comment length to comply with <100 char standard
- Tests organized to match source declaration order
* refactor(test): consolidate tests into Constructor test suite
Per review feedback, move initVersion fuzz test into Constructor
test contract since initVersion() just returns the immutable value
set by the constructor. Delete separate InitVersion test contract.
* refactor(test): rename test function to match container contract
Per review feedback, rename testFuzz_initVersion_validVersion_succeeds
to testFuzz_constructor_validVersion_succeeds since the test is now in
the Constructor_Test contract. Test names should match their container.
* refactor(test): improve test comment clarity
- update comment to better describe constructor validation test
- comment now matches function naming convention
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* op-acceptance-tests: Retry FCU for triggering EL Sync (#17894)
* feat: implement Operator Fee Fix (Jovian) (#17366)
* fix!: multiply operatorFeeScalar by 100 instead of dividing by 1e6
* chore: bump to 1.5.0
* chore: bump to 2.0.0
* refac: gate at Jovian
* missing changes
* update
* reduce diff
* snapshot abi + storage layout + remove unncessary change
* apply comments
* make ci green
* chore: update go.mod
* fix: activate Jovian in e2e tests
* feat: add Jovian upgrate transactions
* fix: update GPO bytecode
* use IsOperatorFeeFix
* add jovian operator fee acceptance test
* chore: add commit hash for GPO bytecode
* chore: remove useless replace in go.mod
* acceptance-tests: push common code for operator fee into dsl
Also use block timestamp to infer isJovian and assert consistency in GPO.
* tweak
* refactor IsthmusCostOracle
* fix link
* tag TODO for followup
* update op-geth
* lint
* lint
* revert changes to op-service/txinclude
According to @joshklop we don't need to make any changes here at the current time, the code is not actually being used anywhere apart from some skipped tests.
* regenerate l1block bytecode and resolve nonce clash
* decouple upgrade transactions, change API to getter and fix tests
* update op-geth reference
* Update packages/contracts-bedrock/test/L2/GasPriceOracle.t.sol
Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
* jovian upgrade transactions: reorder deployer addresses
* just update-op-geth 5c6d276814f2cce1d4dda25ed9e5a3a1c52e59a4
* explicitly disallow user transactions in jovian activation block
* assert on receipts in operator fee acceptance test
* op-e2e/actions: remove jovianActivationBlock test case
replace with running the normalTx test case on the jovian fork
---------
Co-authored-by: leruaa <aurelien.catinon@gmail.com>
Co-authored-by: geoknee <georgeknee@googlemail.com>
Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
* op-acceptance-tests: Reorg then gap filling tests (#17893)
* op-devstack: SingleChain MultiNode preset with TestSequencer
* op-devstack: Add L2CL NoDiscovery preset
* op-devstack: Additional DSLs for L2CL, L2EL
* op-acceptance-tests: Reorg then gap filling tests
* op-node WithNoDiscovery for deflake clp2p
* add TestEndToEndBootstrapApplyWithUpgrade and UpgradeSuperchainConfig scripts (#17826)
* add TestEndToEndBootstrapApplyWithUpgrade and UpgradeSuperchainConfig scripts
* Update packages/contracts-bedrock/scripts/deploy/UpgradeSuperchainConfig.s.sol
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* add comment
* fixes
* fixes
* Update op-deployer/pkg/deployer/integration_test/apply_test.go
Co-authored-by: Maurelian <john@oplabs.co>
* fixes...
* add comments to solidity code
* add comments to solidity code
---------
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: Maurelian <john@oplabs.co>
* refactor(test): improve SafeSend test coverage and quality (#17896)
* refactor(test): improve SafeSend test coverage and quality
- Convert 2 tests to fuzz tests for broader coverage
- Add test for zero address recipient edge case
- Fuzz ETH amounts from 0 to type(uint128).max
- All assertions verify contract self-destruct and balance transfers
* Remove uint128 bound from fuzz tests per reviewer feedback
* Fix overflow issue: bound fuzz tests to uint192 max
Prevents arithmetic overflow in balance calculations while still
testing a very large range (~6.3e57 vs total ETH supply ~1.2e26)
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* supernode: update readme (#17878)
Updated README.md to clarify virtual node configuration and metrics routing.
* make all _TestInit contracts abstract (#17889)
* make all _TestInit contracts abstract
These contracts don't need to run, so they can all be abstract. Local
testing suggests this saves about 30 seconds during the build.
* Make test setup contracts abstract
* fix(op-acceptance-tests): flaky tests; less filtering (#17891)
* op-devstack: dynamically assign geth subprocess p2p listening port (#17904)
Otherwise it defaults to 30303, which can cause test flakes if the
port is already taken.
* fix: no env var manipulation in VerifyOPCM tests (#17813)
* fix: no env var manipulation in VerifyOPCM tests
* Update packages/contracts-bedrock/test/scripts/VerifyOPCM.t.sol
Co-authored-by: Maurelian <john@oplabs.co>
* fix: remove old variable
---------
Co-authored-by: Maurelian <john@oplabs.co>
* op-deployer: re-enable v3 upgrade test with new fork blockNum (#17852)
* Set v0.1.0 and Docker Image Target (#17906)
* op-acceptance-tests: ELP2P down but payload appendable till chain tip (#17895)
* op-acceptance-tests: ELP2P down but payload appendable till chain tip
* Make sure batcher is still down
* Verifier at least reached once the tip of the chain
* remove safe head check
* better err msg
* add KONA_LOG_LEVEL (#17496)
* op-acceptance-tests: disable discovery for test (#17918)
* all: Update op-geth to use blobGasUsed field for DA footprint (#17861)
* op-fetcher: Support the CANNON_KONA FaultDisputeGame (#17656)
* op-fetcher: Support the CANNON_KONA FaultDisputeGame
* cleanup; add test cases for missing cannon-kona
* op-conductor: use op-service HTTP Server for Flashblocks ; fix test flake (#17880)
* Expose bound port of conductor ; allow port assignment ; fix test
* PR Comments
* Use OP-Service HTTPServer
* add requested panic
* PR Comments
* Disable the guard upon ownership transfer (#17808)
* Add SaferSafes as child of the module and guard
* Add ISaferSafes
* Test comment and assertion fixes
* Improve comments
* Make LivenessModule2 and TimelockGuard abstract
Move semver to SaferSafes
semver lock
* fix test contract name
* Move semver to SaferSafes
* Disable the guard and module upon ownership transfer
* Add _disableThisGuard function
* Update tests
* Add config resets
* fmt
* fix test_changeOwnershipToFallback_canRechallenge_succeeds
* Simplify by clearing config directly
* Put _disableThisGuard into child contract
* Add timelockDelay reset on _disableThisGuard
* semver-lock
* Move _disableThisGuard logic into TimelockGuard
* clear livenessSafeConfig at tend of _disableThisModule
* Clarify use of SENTINEL_OWNER
* Fix the ordering of the disableGuard and disableModule calls
* semver-lock
* remove unused imports
* rename _disableThisGuard to _disableGuard
* bump semver
* Add test to remove unrelated guard
* Add SENTINEL_MODULE constant
* Clean up using ternary if
* Reset cancellationThreshold to 0 on changeOwnership
* Fix moduleFound if/else handling
* Clear pending transactions
* Pre-pr fixes
* Add test contract to test name lint exclusions
* fix name of test contract
* Move _disableGuard impl into TimelockGuard
* Add missing natspec
* Add gas limit testing on changeOwnershipToFallback
* Remove interfaces for abstract contracts
* Move state changes out into internal _clearLivenessModule
* Improve names on the internal _disableX methods
* Add clearTimelockGuard function
* Add _disableGuard helper to TLG tests
* Limit number of transactions cancelled to 100
* Revert "Remove interfaces for abstract contracts"
This reverts commit bd032889b639b35b8f512f941de3a924699fe44c.
* Move livenessModule2 address into TestUtils
Reduces diff a bit
* Reduce diff somewhat
* Remove unused arg
* Update packages/contracts-bedrock/src/safe/TimelockGuard.sol
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* Fix iface
* update abi for iface fix
* Do not clear or disable the module during ownership transfer
* Fix inaccurate comment on _disableAndClearGuard
* Further improve comment
* remove unused import
* fix test name
* Do not clear guard during changeOwnershipToFallback
* Remove unused SENTINEL_MODULE var
* Remove dangling comment
* Revert "Remove dangling comment"
This reverts commit d266d12dbc5af68b192c8898b7c97d772a8954a3.
* Fix whitespace
* remove unnecessary internal _clearTimelockGuard function
It's no longer reused in the change ownership call.
* Address feedback
* Add missing assertion
* Move guard slot into constants
* semver-lock
* Remove LivenessModule from semver-lock
* fix: fmt, semver-lock, unused imports
* Remove unused variable
* fix semver lock by resetting old LivenessModule
* fix unused import
---------
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* proofs: Pass game type as a CWIA arg instead of a constructor arg (#17832)
* proofs: Pass game type as a CWIA arg instead of a constructor arg.
* proofs: Remove ReservedGameType check
* fix(Makefile): remove Makefile sharding; rely on (op-e2e) in-test sharding (#17930)
* fix(Makefile): remove Makefile sharding; rely on (op-e2e) in-test sharding
* fix(op-e2e): TestSystemP2PAltSync
Ensure L1 chain config is provided.
* ci: Use a fixed version of mise in golang docker builds (#17954)
* op-devstack/dsl/operator_fee: compute expected vault increase from all transactions in block (#17935)
* op-service: expose BalanceAtHash method
* op-devstack/dsl/operator_fee: compute expected vault increase from all transactions in block
* Revert "op-service: expose BalanceAtHash method"
This reverts commit 078fc26ec1ff3b352a300ed46ee6b979fefb463b.
* revert to checking balance by block number
* query "prior" operator fee vault balance by block number
* ci: Clean up op-deployer caches (#17959)
* ci: Clean up op-deployer caches
We keep running into issues where OPD caches are not properly cleaned up in tests. This adds a stopgap that cleans them up after every test to prevent disk usage exploding on our self-hosted runners.
* bump
* chore(op-acceptance-tests): flake-shake; test promotions (#17951)
* fix(op-acceptance-tests): flake-shake; slack notification channel. (#17931)
* opcm: Update upgrade method for disputegame-v2 (#17874)
* opcm: Update upgrade method for disputegame-v2
* update opcm semver
* check game args; run post-upgrade checks
* update std validator semver lock
* fix assertGameArgsLength error prefix
* opcm and validator fixes
* lint LibGameArgs
* fix interfaces; natspec
* fix natspec in opcm
* forwards-compatible challenger/proposer retrieval
* assert deployed CANNON game parameters
* use v2 getters
* review comments
* fix asr getter name
* use v1 functions for existing upgrade path
* remove dead code (#17937)
* op-node: Fix gossip validation for Jovian blocks (#17940)
Jovian blocks can have a non-zero blobGasUsed value, as the DA footprint
is stored in it.
* Update ManageDrippie.s.sol (#17717)
* remove the superchainProxyAdmin input from upgradeSuperchainConfig function (#17902)
* remove the superchainProxyAdmin input from upgradeSuperchainConfig function
* pull and update
* fix semver
* Require that msgSender be an owner of the Safe (#17900)
* Add SaferSafes as child of the module and guard
* Add ISaferSafes
* Test comment and assertion fixes
* Improve comments
* Make LivenessModule2 and TimelockGuard abstract
Move semver to SaferSafes
semver lock
* fix test contract name
* Move semver to SaferSafes
* Disable the guard and module upon ownership transfer
* Add _disableThisGuard function
* Update tests
* Add config resets
* fmt
* fix test_changeOwnershipToFallback_canRechallenge_succeeds
* Simplify by clearing config directly
* Put _disableThisGuard into child contract
* Add timelockDelay reset on _disableThisGuard
* semver-lock
* Move _disableThisGuard logic into TimelockGuard
* clear livenessSafeConfig at tend of _disableThisModule
* Clarify use of SENTINEL_OWNER
* Fix the ordering of the disableGuard and disableModule calls
* semver-lock
* remove unused imports
* rename _disableThisGuard to _disableGuard
* bump semver
* Add test to remove unrelated guard
* Add SENTINEL_MODULE constant
* Clean up using ternary if
* Reset cancellationThreshold to 0 on changeOwnership
* Fix moduleFound if/else handling
* Clear pending transactions
* Pre-pr fixes
* Add test contract to test name lint exclusions
* fix name of test contract
* Move _disableGuard impl into TimelockGuard
* Add missing natspec
* Add gas limit testing on changeOwnershipToFallback
* Remove interfaces for abstract contracts
* Move state changes out into internal _clearLivenessModule
* Improve names on the internal _disableX methods
* Add clearTimelockGuard function
* Add _disableGuard helper to TLG tests
* Limit number of transactions cancelled to 100
* Revert "Remove interfaces for abstract contracts"
This reverts commit bd032889b639b35b8f512f941de3a924699fe44c.
* Move livenessModule2 address into TestUtils
Reduces diff a bit
* Reduce diff somewhat
* Remove unused arg
* Update packages/contracts-bedrock/src/safe/TimelockGuard.sol
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* Fix iface
* update abi for iface fix
* Do not clear or disable the module during ownership transfer
* Fix inaccurate comment on _disableAndClearGuard
* Further improve comment
* remove unused import
* fix test name
* Do not clear guard during changeOwnershipToFallback
* Remove unused SENTINEL_MODULE var
* Remove dangling comment
* Revert "Remove dangling comment"
This reverts commit d266d12dbc5af68b192c8898b7c97d772a8954a3.
* Fix whitespace
* remove unnecessary internal _clearTimelockGuard function
It's no longer reused in the change ownership call.
* Address feedback
* Add missing assertion
* Move guard slot into constants
* semver-lock
* Remove LivenessModule from semver-lock
* fix: fmt, semver-lock, unused imports
* Remove unused variable
* fix semver lock by resetting old LivenessModule
* fix unused import
* Require that msgSender be an owner of the Safe
* fix compiler error
* Fix placement of _msgSender check
* semver-lock
* Add TimelockGuard_NotOwner test
* Bump semver
* Add test comment, make into fuzz test
* Improvements to SaferSafes styling (#17903)
* Add public getter livenessSafeConfiguration to return a struct rather than tuple
* Use Safe as input type to mappings and functions on LivenessModule2
* Add dividers based on function type
* fmt
* snapshots
* Remove conditional return of 0 in the cancellationThreshold if the guard is not enabled
* rename timelockConfiguration func to timelockDelay
* semver-lock
* Add missing natspec on tests and convert to fuzzing where possible
* fix import and abi snapshot
* fix: off by one error in challenge period test
* fix test name
---------
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* op-service: improve beacon client robustness (#17866)
* op-service: always fall back to fetching blob sidecars
Previously, we only reverted to fetching sidecars when an error was
received from the beacon server. In an attempt to be more robust,
we also fetch sidecars when the beacon server gives us a semantically
invalid response.
* op-service: rearrange blobs based on provided hashes
The behavior in the post-Fulu /blobs/ happy path and the
/blob_sidecars/ fallback slightly differed: in the former case,
returned blobs were ordered based their index in the blob, while in the
latter case they were ordered based on the provided hashes.
This bug was not caught in testing because all calls to BeaconBlobs
provide a slice of hashes sorted by index.
* GasPriceOracle: remove saturating math from getOperatorFee (jovian) (#17913)
* GasPriceOracle: remove saturating math fro getOperatorFee (isthmus and jovian)
Extend test coverage to edge cases
* restore Isthmys formula
* fix test
* use library
* lint
* semver bump
* modify semver and regenerate lock file
* fix(op-deployer): use temp cache dir for cli tests (#17965)
* Improve SaferSafes test suite. (#17949)
* Add SaferSafes as child of the module and guard
* Add ISaferSafes
* Test comment and assertion fixes
* Improve comments
* Make LivenessModule2 and TimelockGuard abstract
Move semver to SaferSafes
semver lock
* fix test contract name
* Move semver to SaferSafes
* Disable the guard and module upon ownership transfer
* Add _disableThisGuard function
* Update tests
* Add config resets
* fmt
* fix test_changeOwnershipToFallback_canRechallenge_succeeds
* Simplify by clearing config directly
* Put _disableThisGuard into child contract
* Add timelockDelay reset on _disableThisGuard
* semver-lock
* Move _disableThisGuard logic into TimelockGuard
* clear livenessSafeConfig at tend of _disableThisModule
* Clarify use of SENTINEL_OWNER
* Fix the ordering of the disableGuard and disableModule calls
* semver-lock
* remove unused imports
* rename _disableThisGuard to _disableGuard
* bump semver
* Add test to remove unrelated guard
* Add SENTINEL_MODULE constant
* Clean up using ternary if
* Reset cancellationThreshold to 0 on changeOwnership
* Fix moduleFound if/else handling
* Clear pending transactions
* Pre-pr fixes
* Add test contract to test name lint exclusions
* fix name of test contract
* Move _disableGuard impl into TimelockGuard
* Add missing natspec
* Add gas limit testing on changeOwnershipToFallback
* Remove interfaces for abstract contracts
* Move state changes out into internal _clearLivenessModule
* Improve names on the internal _disableX methods
* Add clearTimelockGuard function
* Add _disableGuard helper to TLG tests
* Limit number of transactions cancelled to 100
* Revert "Remove interfaces for abstract contracts"
This reverts commit bd032889b639b35b8f512f941de3a924699fe44c.
* Move livenessModule2 address into TestUtils
Reduces diff a bit
* Reduce diff somewhat
* Remove unused arg
* Update packages/contracts-bedrock/src/safe/TimelockGuard.sol
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* Fix iface
* update abi for iface fix
* Do not clear or disable the module during ownership transfer
* Fix inaccurate comment on _disableAndClearGuard
* Further improve comment
* remove unused import
* fix test name
* Do not clear guard during changeOwner…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #17466 to update op-geth to ethereum-optimism/op-geth#694, finally using the
blobGasUsedfield for the DA footprint, instead of sharing thegasUsedfield like in the previous design.Tests
Fixed and extended existing acceptance test to cover configurability and explicitly assert correct base fee update calculation.
Also improved some devstack DSL functions to offer more generic
WaitFor...methods.Action tests are added in a follow up.
Metadata
Fixes ethereum-optimism/op-geth#691