-
Notifications
You must be signed in to change notification settings - Fork 4k
Disable the guard upon ownership transfer #17808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 71 commits
Commits
Show all changes
74 commits
Select commit
Hold shift + click to select a range
82e8ce3
Add SaferSafes as child of the module and guard
maurelian b6a5561
Add ISaferSafes
maurelian 3a33850
Test comment and assertion fixes
maurelian 81399b2
Improve comments
maurelian 05aa13d
Make LivenessModule2 and TimelockGuard abstract
maurelian d35175c
fix test contract name
maurelian 3da8e5b
Move semver to SaferSafes
maurelian 64e0153
Disable the guard and module upon ownership transfer
maurelian 300ab95
Add _disableThisGuard function
maurelian 5efbf2a
Update tests
maurelian 6e2acad
Add config resets
maurelian 8f161cf
fmt
maurelian b5461ff
fix test_changeOwnershipToFallback_canRechallenge_succeeds
maurelian 46fb155
Simplify by clearing config directly
maurelian 993232a
Put _disableThisGuard into child contract
maurelian 7f1d9ef
Add timelockDelay reset on _disableThisGuard
maurelian aa50113
semver-lock
maurelian 6cb5167
Move _disableThisGuard logic into TimelockGuard
maurelian 74113a7
clear livenessSafeConfig at tend of _disableThisModule
maurelian 7242c80
Clarify use of SENTINEL_OWNER
maurelian cfb6110
Fix the ordering of the disableGuard and disableModule calls
maurelian 3b1132b
semver-lock
maurelian 48663a6
remove unused imports
maurelian c6ea913
rename _disableThisGuard to _disableGuard
maurelian 819a246
bump semver
maurelian fcd9fa4
Add test to remove unrelated guard
maurelian a643404
Add SENTINEL_MODULE constant
maurelian a2d6019
Clean up using ternary if
maurelian 539dd58
Reset cancellationThreshold to 0 on changeOwnership
maurelian 9db0218
Fix moduleFound if/else handling
maurelian f7763dc
Clear pending transactions
maurelian f0855e5
Pre-pr fixes
maurelian 6b2b25d
Add test contract to test name lint exclusions
maurelian cb58df1
fix name of test contract
maurelian 8dd8e55
Move _disableGuard impl into TimelockGuard
maurelian a36b79e
Add missing natspec
maurelian 62fed33
Add gas limit testing on changeOwnershipToFallback
maurelian bd03288
Remove interfaces for abstract contracts
maurelian 97e49d2
Merge branch 'develop' into jm/disable-extensions-on-transfer
maurelian f75e019
Move state changes out into internal _clearLivenessModule
maurelian b50c952
Improve names on the internal _disableX methods
maurelian 866067b
Add clearTimelockGuard function
maurelian 1d4fdda
Add _disableGuard helper to TLG tests
maurelian 220a421
Limit number of transactions cancelled to 100
maurelian 275f950
Revert "Remove interfaces for abstract contracts"
maurelian e4b4457
Move livenessModule2 address into TestUtils
maurelian 4bf722e
Reduce diff somewhat
maurelian 67f13d2
Remove unused arg
maurelian f62065a
Update packages/contracts-bedrock/src/safe/TimelockGuard.sol
maurelian 415d98f
Fix iface
maurelian 9b0e831
update abi for iface fix
maurelian 4ee99aa
Do not clear or disable the module during ownership transfer
maurelian 75430d4
Fix inaccurate comment on _disableAndClearGuard
maurelian b459c34
Further improve comment
maurelian da19fe8
remove unused import
maurelian 491f484
fix test name
maurelian 5d36c21
Merge branch 'develop' into jm/disable-extensions-on-transfer
maurelian e6a057b
Merge branch 'develop' into jm/disable-extensions-on-transfer
maurelian 56b439d
Do not clear guard during changeOwnershipToFallback
maurelian 4f499e8
Remove unused SENTINEL_MODULE var
maurelian d266d12
Remove dangling comment
maurelian 9f50cdc
Revert "Remove dangling comment"
maurelian 3ce855f
Fix whitespace
maurelian 7a93d4e
Merge branch 'develop' into jm/disable-extensions-on-transfer
maurelian af77e1b
remove unnecessary internal _clearTimelockGuard function
maurelian 39434fc
Address feedback
maurelian 3f2595b
Add missing assertion
maurelian 6977109
Move guard slot into constants
maurelian 0b38113
semver-lock
maurelian e525173
Remove LivenessModule from semver-lock
maurelian 07ecba6
fix: fmt, semver-lock, unused imports
maurelian 3f2a72c
Remove unused variable
maurelian 7369668
fix semver lock by resetting old LivenessModule
maurelian 0434bfa
fix unused import
maurelian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.