Skip to content

feat: OPCM creator pattern support for addGameType #17745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajsutton wants to merge 8 commits into from
Closed

feat: OPCM creator pattern support for addGameType #17745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ff5d425
fix: override inheritance for helper function
stevennevins Sep 17, 2025
a852c53
chore: remove commented function
stevennevins Sep 17, 2025
8b9f371
fix: test setup
stevennevins Sep 17, 2025
57d0b67
fix: add game type v2 test
stevennevins Sep 18, 2025
8e27f45
fix: correct v2 dispute game test setup for addGameType
stevennevins Sep 19, 2025
a4a0133
fix: conflict from duplicate helper
stevennevins Sep 19, 2025
45de2e3
fix: remove empty contract
stevennevins Sep 19, 2025
9118e87
opcm: Fix test and validation failures
ajsutton Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/contracts-bedrock/scripts/checks/test-validation/exclusions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,5 @@ contracts = [
"OptimismPortal2_MigrateLiquidity_Test", # Interop tests hosted in the OptimismPortal2 test file
"OptimismPortal2_MigrateToSuperRoots_Test", # Interop tests hosted in the OptimismPortal2 test file
"OptimismPortal2_UpgradeInterop_Test", # Interop tests hosted in the OptimismPortal2 test file
"OPContractsManager_TestBase", # Setup helper for creator pattern dispute games
]
10 changes: 0 additions & 10 deletions packages/contracts-bedrock/snapshots/abi/OPContractsManager.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,16 +432,6 @@
"internalType": "contract IDelayedWETH",
"name": "delayedWETHPermissionlessGameProxy",
"type": "address"
},
{
"internalType": "contract IFaultDisputeGameV2",
"name": "faultDisputeGameV2",
"type": "address"
},
{
"internalType": "contract IPermissionedDisputeGameV2",
"name": "permissionedDisputeGameV2",
"type": "address"
}
],
"internalType": "struct OPContractsManager.DeployOutput",
Expand Down
10 changes: 0 additions & 10 deletions packages/contracts-bedrock/snapshots/abi/OPContractsManagerDeployer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,16 +330,6 @@
"internalType": "contract IDelayedWETH",
"name": "delayedWETHPermissionlessGameProxy",
"type": "address"
},
{
"internalType": "contract IFaultDisputeGameV2",
"name": "faultDisputeGameV2",
"type": "address"
},
{
"internalType": "contract IPermissionedDisputeGameV2",
"name": "permissionedDisputeGameV2",
"type": "address"
}
],
"internalType": "struct OPContractsManager.DeployOutput",
Expand Down
4 changes: 2 additions & 2 deletions packages/contracts-bedrock/snapshots/semver-lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
"sourceCodeHash": "0xfca613b5d055ffc4c3cbccb0773ddb9030abedc1aa6508c9e2e7727cc0cd617b"
},
"src/L1/OPContractsManager.sol:OPContractsManager": {
"initCodeHash": "0x01d2eceec1f7a9f7ca232cdda10da279477c7418545be4834989ab0b5007dd40",
"sourceCodeHash": "0xd226c3b4242b6a4b69ec0554146866dc262110ce3b5ce7e594d5dc0013acb7f2"
"initCodeHash": "0x52b95f66d9f57020b90c6f1ae1e1bd329c7ed32f3357d2b73f200a7f339c68da",
"sourceCodeHash": "0x8916646d6b7f5eddb545bbc5f0a9b85b191fa52a1d3fb935c022a841da33d5be"
},
"src/L1/OPContractsManagerStandardValidator.sol:OPContractsManagerStandardValidator": {
"initCodeHash": "0x57d6a6729d887ead009d518e8f17fa0d26bfc97b8efe1494ab4ef8dbb000d109",
Expand Down
Loading