op-e2e/actions: add L1 Osaka activation test#17522
op-e2e/actions: add L1 Osaka activation test#17522DenseDenise wants to merge 8 commits intoethereum-optimism:developfrom
Conversation
geoknee
added
the
H-l1-fusaka-defense
|
/ci authorize d591144 |
|
@geoknee Hi should be good now |
geoknee
changed the title
geoknee
changed the title
|
/ci authorize ad87c6f |
|
WOW thanks for the additional fixing, and the ci looks good @geoknee |
|
/ci authorize 93271d9 |
| // Build L1 blocks to trigger Fusaka activation | ||
| // TODO in the current version of op-geth, the blob parameters don't change between Prague and Osaka. | ||
| // So this test is no useful until we can activate different blob parameters. |
There was a problem hiding this comment.
Highlighting this. We should be able to override the blob schedule for osaka and trigger a test failure (currently it passes).
There was a problem hiding this comment.
Got it, should we create a issue or draft-PR for hint? or its okay and just keep it in mind?
There was a problem hiding this comment.
I'm going to keep working on this branch (if that's ok with you) and try to get the test to fail with a custom blob schedule. Then we will get a review from another teammate and look to merge the PR (potentially with the test skipped).
There was a problem hiding this comment.
This bug may be preventing us from installing a custom blob schedule ethereum-optimism/op-geth#685
There was a problem hiding this comment.
Got around that with a custom op-geth build here #17666
There was a problem hiding this comment.
I'm going to keep working on this branch (if that's ok with you) and try to get the test to fail with a custom blob schedule. Then we will get a review from another teammate and look to merge the PR (potentially with the test skipped).
Its 100% fine with me, sorry for slow respond, stuck in some personal task recently.
There was a problem hiding this comment.
Got around that with a custom op-geth build here #17666
Looks like this has been merged, should I close this PR now?
There was a problem hiding this comment.
Yep I will close it. Thanks for kicking this off, you are attributed on the merged PR.
2 participants
closes #17500