feat: opcm creator pattern integrate addGameType for v2 games#17464
Closed
stevennevins wants to merge 52 commits intodevelopfrom
Closed
feat: opcm creator pattern integrate addGameType for v2 games#17464stevennevins wants to merge 52 commits intodevelopfrom
stevennevins wants to merge 52 commits intodevelopfrom
Conversation
stevennevins
force-pushed
the
snevins/issue-17260/creator-pattern-opcm-addGameType
branch
from
375d774 to
4ee1e4b
Compare
stevennevins
force-pushed
the
snevin/issue-17257/creator-pattern-opcm-deploy
branch
from
91ccb5b to
41c046d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## snevin/issue-17257/creator-pattern-opcm-deploy #17464 +/- ##
==================================================================================
- Coverage 95.94% 95.91% -0.04%
==================================================================================
Files 113 113
Lines 5179 5189 +10
==================================================================================
+ Hits 4969 4977 +8
- Misses 210 212 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
stevennevins
force-pushed
the
snevins/issue-17260/creator-pattern-opcm-addGameType
branch
from
efe73f6 to
fa911d6
Compare
stevennevins
force-pushed
the
snevin/issue-17257/creator-pattern-opcm-deploy
branch
4 times, most recently
from
38288fb to
a529bb5
Compare
Rename _isV2Implementation to _isV2DisputeGameImplementation for better clarity about what types of contracts this function checks for.
…ting output implementation on outupt struct
stevennevins
force-pushed
the
snevin/issue-17257/creator-pattern-opcm-deploy
branch
from
77c93c1 to
c9aebae
Compare
stevennevins
force-pushed
the
snevins/issue-17260/creator-pattern-opcm-addGameType
branch
from
1d41ac4 to
1005541
Compare
This was referenced Oct 7, 2025
Base automatically changed from
snevin/issue-17257/creator-pattern-opcm-deploy
to
develop
October 14, 2025 18:04
Contributor
|
Closing in favour of #17782 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates the v2 creator pattern games into OPCM and validates the behavior behind a feature flag
Tests
Adds tests to validate the behavior for addGameType in both states for the feature flag toggle
Additional context
N/A
Metadata
Closes #17260