Skip to content

fix: remove unused variables from FDG_V2 test file #17400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevennevins merged 1 commit into from
Sep 10, 2025
Merged

fix: remove unused variables from FDG_V2 test file #17400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 0 additions & 48 deletions packages/contracts-bedrock/test/dispute/v2/FaultDisputeGameV2.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,14 +229,6 @@ contract FaultDisputeGameV2_Constructor_Test is FaultDisputeGameV2_TestInit {
/// @notice Tests that the constructor of the `FaultDisputeGame` reverts when the
/// `MAX_GAME_DEPTH` parameter is greater than `LibPosition.MAX_POSITION_BITLEN - 1`.
function testFuzz_constructor_maxDepthTooLarge_reverts(uint256 _maxGameDepth) public {
IPreimageOracle oracle = IPreimageOracle(
DeployUtils.create1({
_name: "PreimageOracle",
_args: DeployUtils.encodeConstructor(abi.encodeCall(IPreimageOracle.__constructor__, (0, 0)))
})
);
AlphabetVM alphabetVM = new AlphabetVM(absolutePrestate, oracle);

_maxGameDepth = bound(_maxGameDepth, LibPosition.MAX_POSITION_BITLEN, type(uint256).max - 1);
vm.expectRevert(MaxDepthTooLarge.selector);
DeployUtils.create1({
Expand All @@ -261,16 +253,6 @@ contract FaultDisputeGameV2_Constructor_Test is FaultDisputeGameV2_TestInit {
/// @notice Tests that the constructor of the `FaultDisputeGame` reverts when the `_splitDepth`
/// parameter is greater than or equal to the `MAX_GAME_DEPTH`
function testFuzz_constructor_invalidSplitDepth_reverts(uint256 _splitDepth) public {
AlphabetVM alphabetVM = new AlphabetVM(
absolutePrestate,
IPreimageOracle(
DeployUtils.create1({
_name: "PreimageOracle",
_args: DeployUtils.encodeConstructor(abi.encodeCall(IPreimageOracle.__constructor__, (0, 0)))
})
)
);

uint256 maxGameDepth = 2 ** 3;
_splitDepth = bound(_splitDepth, maxGameDepth - 1, type(uint256).max);
vm.expectRevert(InvalidSplitDepth.selector);
Expand All @@ -296,16 +278,6 @@ contract FaultDisputeGameV2_Constructor_Test is FaultDisputeGameV2_TestInit {
/// @notice Tests that the constructor of the `FaultDisputeGame` reverts when the `_splitDepth`
/// parameter is less than the minimum split depth (currently 2).
function testFuzz_constructor_lowSplitDepth_reverts(uint256 _splitDepth) public {
AlphabetVM alphabetVM = new AlphabetVM(
absolutePrestate,
IPreimageOracle(
DeployUtils.create1({
_name: "PreimageOracle",
_args: DeployUtils.encodeConstructor(abi.encodeCall(IPreimageOracle.__constructor__, (0, 0)))
})
)
);

uint256 minSplitDepth = 2;
_splitDepth = bound(_splitDepth, 0, minSplitDepth - 1);
vm.expectRevert(InvalidSplitDepth.selector);
Expand Down Expand Up @@ -336,16 +308,6 @@ contract FaultDisputeGameV2_Constructor_Test is FaultDisputeGameV2_TestInit {
)
public
{
AlphabetVM alphabetVM = new AlphabetVM(
absolutePrestate,
IPreimageOracle(
DeployUtils.create1({
_name: "PreimageOracle",
_args: DeployUtils.encodeConstructor(abi.encodeCall(IPreimageOracle.__constructor__, (0, 0)))
})
)
);

// Force the clock extension * 2 to be greater than the max clock duration, but keep things
// within bounds of the uint64 type.
_maxClockDuration = uint64(bound(_maxClockDuration, 0, type(uint64).max / 2 - 1));
Expand Down Expand Up @@ -374,16 +336,6 @@ contract FaultDisputeGameV2_Constructor_Test is FaultDisputeGameV2_TestInit {
/// @notice Tests that the constructor of the `FaultDisputeGame` reverts when the `_gameType`
/// parameter is set to the reserved `type(uint32).max` game type.
function test_constructor_reservedGameType_reverts() public {
AlphabetVM alphabetVM = new AlphabetVM(
absolutePrestate,
IPreimageOracle(
DeployUtils.create1({
_name: "PreimageOracle",
_args: DeployUtils.encodeConstructor(abi.encodeCall(IPreimageOracle.__constructor__, (0, 0)))
})
)
);

vm.expectRevert(ReservedGameType.selector);
DeployUtils.create1({
_name: "FaultDisputeGameV2",
Expand Down