Closed
Conversation
42f6601 to
6086798
Compare
joshklop
commented
Aug 29, 2025
tynes
reviewed
Aug 29, 2025
6086798 to
3331144
Compare
joshklop
commented
Aug 29, 2025
| uint256 public l2GenesisBlockGasLimit; | ||
| uint32 public basefeeScalar; | ||
| uint32 public blobbasefeeScalar; | ||
| uint32 public daFootprintGasScalar; |
Contributor
Author
Contributor
There was a problem hiding this comment.
@joshklop did you figure out what happened here?
af0f215 to
564ff19
Compare
Contributor
Author
|
Personal to-do list for next week.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #17269 +/- ##
============================================
- Coverage 95.84% 0 -95.85%
============================================
Files 110 0 -110
Lines 5102 0 -5102
============================================
- Hits 4890 0 -4890
+ Misses 212 0 -212
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
8380c5b to
86aa8a9
Compare
0901274 to
3af6b76
Compare
3af6b76 to
f5a0e95
Compare
geoknee
reviewed
Sep 10, 2025
Comment on lines
+38
to
+39
| OPERATOR_FEE_PARAMS, | ||
| DA_FOOTPRINT_GAS_SCALAR |
Contributor
There was a problem hiding this comment.
Just a heads up that you will soon need to rebase this work on the min-base-fee work (likely to land first), which has already extended this enum and bumped the semver.
Contributor
Author
There was a problem hiding this comment.
Yeah I've noticed a few conflicts and have paused work here for now.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.