Skip to content

Comments

jovian: make da footprint configurable#17269

Closed
joshklop wants to merge 1 commit intodevelopfrom
joshklop/da-footprint-config
Closed

jovian: make da footprint configurable#17269
joshklop wants to merge 1 commit intodevelopfrom
joshklop/da-footprint-config

Conversation

@joshklop
Copy link
Contributor

No description provided.

@joshklop joshklop force-pushed the joshklop/da-footprint-config branch from 42f6601 to 6086798 Compare August 29, 2025 00:59
@joshklop joshklop force-pushed the joshklop/da-footprint-config branch from 6086798 to 3331144 Compare August 29, 2025 23:02
uint256 public l2GenesisBlockGasLimit;
uint32 public basefeeScalar;
uint32 public blobbasefeeScalar;
uint32 public daFootprintGasScalar;
Copy link
Contributor Author

@joshklop joshklop Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite being present in the diff here, it appears that the operatorFee* parameters never made it through to develop.

Should I add them back in a separate PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshklop did you figure out what happened here?

@joshklop joshklop force-pushed the joshklop/da-footprint-config branch 2 times, most recently from af0f215 to 564ff19 Compare August 29, 2025 23:10
@joshklop
Copy link
Contributor Author

joshklop commented Aug 29, 2025

Personal to-do list for next week.

  • Get existing tests passing.
  • Rebase.
  • Add spacer.
  • Go unit tests (done, except for jovian_upgrade_transactions_test.go, which I believe is blocked on the spec)
  • Switch from uint32 to uint16
  • Acceptance test(s).
    • Jovian successfully activated at genesis, configured later
    • Jovian successfully activated after genesis, configured later

@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (8328a42) to head (f5a0e95).
⚠️ Report is 65 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #17269       +/-   ##
============================================
- Coverage    95.84%        0   -95.85%     
============================================
  Files          110        0      -110     
  Lines         5102        0     -5102     
============================================
- Hits          4890        0     -4890     
+ Misses         212        0      -212     
Flag Coverage Δ
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 110 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joshklop joshklop force-pushed the joshklop/da-footprint-config branch 21 times, most recently from 8380c5b to 86aa8a9 Compare September 4, 2025 21:23
@joshklop joshklop force-pushed the joshklop/da-footprint-config branch 12 times, most recently from 0901274 to 3af6b76 Compare September 5, 2025 20:34
Comment on lines +38 to +39
OPERATOR_FEE_PARAMS,
DA_FOOTPRINT_GAS_SCALAR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up that you will soon need to rebase this work on the min-base-fee work (likely to land first), which has already extended this enum and bumped the semver.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I've noticed a few conflicts and have paused work here for now.

@geoknee geoknee added the H-jovian Hardfork: change is planned for jovian upgrade label Sep 11, 2025
@joshklop joshklop closed this Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

H-jovian Hardfork: change is planned for jovian upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants