Skip to content

op-node: remove PromoteFinalizedEvent#17165

Merged
joshklop merged 1 commit into
developfrom
joshklop/rm-promotefinalized
Aug 20, 2025
Merged

op-node: remove PromoteFinalizedEvent#17165
joshklop merged 1 commit into
developfrom
joshklop/rm-promotefinalized

op-node: remove PromoteFinalizedEvent

9970bb1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 20, 2025 in 0s

42.52% (-2.13%) compared to f9e7aac

View this Pull Request on Codecov

42.52% (-2.13%) compared to f9e7aac

Details

Codecov Report

❌ Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.52%. Comparing base (f9e7aac) to head (9970bb1).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
op-node/rollup/engine/engine_controller.go 69.23% 3 Missing and 1 partial ⚠️
op-node/rollup/driver/driver.go 0.00% 2 Missing ⚠️
op-node/rollup/interop/indexing/system.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17165      +/-   ##
===========================================
- Coverage    44.65%   42.52%   -2.13%     
===========================================
  Files         1424     1318     -106     
  Lines       115198   110615    -4583     
===========================================
- Hits         51436    47038    -4398     
+ Misses       60071    59883     -188     
- Partials      3691     3694       +3     
Files with missing lines Coverage Δ
op-node/rollup/engine/events.go 100.00% <ø> (ø)
op-node/rollup/finality/altda.go 100.00% <100.00%> (ø)
op-node/rollup/finality/finalizer.go 88.12% <100.00%> (+0.07%) ⬆️
op-node/rollup/interop/indexing/system.go 19.46% <0.00%> (+0.10%) ⬆️
op-node/rollup/driver/driver.go 0.00% <0.00%> (ø)
op-node/rollup/engine/engine_controller.go 82.06% <69.23%> (+1.95%) ⬆️

... and 110 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.