Skip to content

Comments

op-batcher: improve default throttle parameters#17148

Merged
sebastianst merged 1 commit intodevelopfrom
seb/impr-throttle-params
Aug 19, 2025
Merged

op-batcher: improve default throttle parameters#17148
sebastianst merged 1 commit intodevelopfrom
seb/impr-throttle-params

Conversation

@sebastianst
Copy link
Member

Description

Testing showed that the lower threshold is reached too quickly, so it's increased to ~4x 6-blob-transactions. The higher threshold is also increased to widen the throttling range, to 4x the lower threshold, so about ~16x 6-blob-transactions.

The upper tx size throttle limit is also doubled to 20k.

@sebastianst sebastianst requested review from a team as code owners August 19, 2025 16:08
@sebastianst sebastianst requested review from joshklop and mds1 and removed request for mds1 August 19, 2025 16:08
@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (b4c6919) to head (3c8399c).
⚠️ Report is 22 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #17148       +/-   ##
============================================
- Coverage    45.74%        0   -45.75%     
============================================
  Files         1478        0     -1478     
  Lines       120115        0   -120115     
============================================
- Hits         54945        0    -54945     
+ Misses       61320        0    -61320     
+ Partials      3850        0     -3850     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1478 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sebastianst sebastianst force-pushed the seb/impr-throttle-params branch from 23a5988 to 3c8399c Compare August 19, 2025 16:34
@sebastianst sebastianst enabled auto-merge August 19, 2025 16:34
@sebastianst sebastianst added this pull request to the merge queue Aug 19, 2025
Merged via the queue into develop with commit 061043e Aug 19, 2025
66 checks passed
@sebastianst sebastianst deleted the seb/impr-throttle-params branch August 19, 2025 17:17
@geoknee geoknee added the A-op-batcher Area: op-batcher label Aug 22, 2025
leopoldjoy pushed a commit to leopoldjoy/optimism that referenced this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-op-batcher Area: op-batcher

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants