Skip to content

Comments

feat(op-acceptance-tests): migrate operator fee tests from devnet-sdk to op-devstack#17130

Merged
scharissis merged 1 commit intodevelopfrom
scharissis/op-acceptance-tests/isthmus-operator-fee-devstack
Aug 19, 2025
Merged

feat(op-acceptance-tests): migrate operator fee tests from devnet-sdk to op-devstack#17130
scharissis merged 1 commit intodevelopfrom
scharissis/op-acceptance-tests/isthmus-operator-fee-devstack

Conversation

@scharissis
Copy link
Contributor

@scharissis scharissis commented Aug 19, 2025

Convert isthmus operator fee acceptance tests to use the new op-devstack
testing framework instead of the legacy devnet-sdk. Updates test interfaces
and types while preserving test functionality.

Main changes:

  • Update imports from devnet-sdk/testing/systest to op-devstack/devtest
  • Convert test interface types (systest.T → devtest.T)
  • Simplify unit tests (removed implementations of unused functions)
  • Mark unused utility functions with conversion notes

Metadata

Fixes ethereum-optimism/infra#442

@scharissis scharissis requested a review from a team as a code owner August 19, 2025 06:15
@scharissis scharissis requested a review from joshklop August 19, 2025 06:15
@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 2.52%. Comparing base (a432e4f) to head (c34893b).
⚠️ Report is 8 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (a432e4f) and HEAD (c34893b). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (a432e4f) HEAD (c34893b)
2 1
cannon-go-tests-64 2 0
contracts-bedrock-tests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #17130       +/-   ##
============================================
- Coverage    45.42%    2.52%   -42.90%     
============================================
  Files         1478       31     -1447     
  Lines       120071     2928   -117143     
============================================
- Hits         54541       74    -54467     
+ Misses       61701     2844    -58857     
+ Partials      3829       10     -3819     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1469 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…-devstack

Convert isthmus operator fee acceptance tests to use the new op-devstack
testing framework instead of the legacy devnet-sdk. Updates test interfaces
and types while preserving test functionality.

Main changes:
- Update imports from devnet-sdk/testing/systest to op-devstack/devtest
- Convert test interface types (systest.T → devtest.T)
- Simplify unit tests (removed implementations of unused functions)
- Mark unused utility functions with conversion notes
@scharissis scharissis force-pushed the scharissis/op-acceptance-tests/isthmus-operator-fee-devstack branch from 8127e0a to c34893b Compare August 19, 2025 06:47
@scharissis scharissis added this pull request to the merge queue Aug 19, 2025
Merged via the queue into develop with commit e237c74 Aug 19, 2025
68 checks passed
@scharissis scharissis deleted the scharissis/op-acceptance-tests/isthmus-operator-fee-devstack branch August 19, 2025 23:23
leopoldjoy pushed a commit to leopoldjoy/optimism that referenced this pull request Aug 22, 2025
…-devstack (ethereum-optimism#17130)

Convert isthmus operator fee acceptance tests to use the new op-devstack
testing framework instead of the legacy devnet-sdk. Updates test interfaces
and types while preserving test functionality.

Main changes:
- Update imports from devnet-sdk/testing/systest to op-devstack/devtest
- Convert test interface types (systest.T → devtest.T)
- Simplify unit tests (removed implementations of unused functions)
- Mark unused utility functions with conversion notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[acceptance] Port TestBalanceSnapshot to Devstack

2 participants