Skip to content

Comments

op-acceptance-tests: fix TestNotTruncateDatabaseOnRestartWithExistingDatabase to run by itself#17127

Merged
mslipper merged 1 commit intodevelopfrom
aj/fix-safeheaddb-test
Aug 19, 2025
Merged

op-acceptance-tests: fix TestNotTruncateDatabaseOnRestartWithExistingDatabase to run by itself#17127
mslipper merged 1 commit intodevelopfrom
aj/fix-safeheaddb-test

Conversation

@ajsutton
Copy link
Contributor

Description

Safe head db doesn't record when the L2 genesis becomes safe (for many reasons but not possible to make a proposal for the genesis block because it has to be after the anchor state block). When the test ran after the previous test, it's starting head was non-zero but when it ran by itself the initial safe block would often be 0 and then the test failed because the safe head db didn't go all the way back to 0.

Now it records the safe head after it has advanced at least once so it's always non-zero. Still requires the safe head data to persist across the restart which is the key requirement.

Metadata

fixes #17083

@ajsutton ajsutton requested a review from a team as a code owner August 19, 2025 01:46
@ajsutton ajsutton requested a review from zhwrd August 19, 2025 01:46
@mslipper mslipper added this pull request to the merge queue Aug 19, 2025
Merged via the queue into develop with commit 673e1a0 Aug 19, 2025
68 checks passed
@mslipper mslipper deleted the aj/fix-safeheaddb-test branch August 19, 2025 04:25
janjakubnanista pushed a commit that referenced this pull request Aug 19, 2025
leopoldjoy pushed a commit to leopoldjoy/optimism that referenced this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

op-acceptance-tests: Revise safedb EL sync tests

2 participants