Skip to content

Comments

cannon,op-challenger: Add metric to report i-cache misses#17123

Merged
Inphi merged 1 commit intodevelopfrom
inphi/cannon-cache-miss
Aug 19, 2025
Merged

cannon,op-challenger: Add metric to report i-cache misses#17123
Inphi merged 1 commit intodevelopfrom
inphi/cannon-cache-miss

Conversation

@Inphi
Copy link
Contributor

@Inphi Inphi commented Aug 18, 2025

The instruction pre-heap contains a cache of decoded instructions. It is initialized the first time Cannon is executed using a 2 GiB region. In almost all cases, this is sufficient to cover all instructions in a program. In rare cases, such as when the program exceeds 2 GiB or due to misconfiguration, a cache miss may occur. Detecting this today is not straightforward.

This patch adds a metric to track cache misses in the pre-heap, making it easier to identify when they happen.

@Inphi Inphi requested review from a team as code owners August 18, 2025 21:26
@Inphi Inphi requested a review from pauldowman August 18, 2025 21:26
@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.39%. Comparing base (2da6ec7) to head (e90e569).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
cannon/mipsevm/multithreaded/stats.go 37.50% 5 Missing ⚠️
op-challenger/metrics/vm.go 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17123      +/-   ##
===========================================
+ Coverage    43.74%   45.39%   +1.64%     
===========================================
  Files         1372     1478     +106     
  Lines       115501   120096    +4595     
===========================================
+ Hits         50524    54514    +3990     
- Misses       61134    61758     +624     
+ Partials      3843     3824      -19     
Flag Coverage Δ
cannon-go-tests-64 65.95% <44.44%> (-0.05%) ⬇️
contracts-bedrock-tests 96.28% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cannon/mipsevm/multithreaded/mips.go 91.66% <100.00%> (+0.02%) ⬆️
op-challenger/game/fault/trace/vm/executor.go 61.01% <100.00%> (+0.33%) ⬆️
op-challenger/metrics/vm.go 32.40% <60.00%> (+1.33%) ⬆️
cannon/mipsevm/multithreaded/stats.go 84.12% <37.50%> (-6.79%) ⬇️

... and 122 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Inphi Inphi added this pull request to the merge queue Aug 19, 2025
Merged via the queue into develop with commit b4c6919 Aug 19, 2025
68 checks passed
@Inphi Inphi deleted the inphi/cannon-cache-miss branch August 19, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants