Skip to content

Comments

op-node: remove PendingSafeRequestEvent#17122

Merged
joshklop merged 1 commit intodevelopfrom
joshklop/rm-pendingsaferequest
Aug 20, 2025
Merged

op-node: remove PendingSafeRequestEvent#17122
joshklop merged 1 commit intodevelopfrom
joshklop/rm-pendingsaferequest

Conversation

@joshklop
Copy link
Contributor

No description provided.

@joshklop joshklop force-pushed the joshklop/rm-pendingsaferequest branch 2 times, most recently from 272812d to 9546073 Compare August 18, 2025 20:06
@joshklop joshklop marked this pull request as ready for review August 18, 2025 20:07
@joshklop joshklop requested review from a team as code owners August 18, 2025 20:07
@joshklop joshklop requested review from ajsutton and teddyknox August 18, 2025 20:07
@joshklop joshklop force-pushed the joshklop/rm-pendingsaferequest branch 2 times, most recently from abd0a41 to 9cff634 Compare August 18, 2025 21:06
@joshklop joshklop requested a review from teddyknox August 18, 2025 21:10
@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 61.90476% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.49%. Comparing base (a1a200a) to head (c03786f).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
op-program/client/driver/driver.go 0.00% 6 Missing ⚠️
op-node/rollup/attributes/attributes.go 66.66% 1 Missing ⚠️
op-node/rollup/driver/state.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a1a200a) and HEAD (c03786f). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (a1a200a) HEAD (c03786f)
contracts-bedrock-tests 2 0
cannon-go-tests-64 2 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #17122       +/-   ##
============================================
- Coverage    62.42%   42.49%   -19.94%     
============================================
  Files          192     1318     +1126     
  Lines        12305   110624    +98319     
============================================
+ Hits          7682    47011    +39329     
- Misses        4465    59921    +55456     
- Partials       158     3692     +3534     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-node/rollup/attributes/testutils.go 75.00% <100.00%> (ø)
op-node/rollup/engine/engine_controller.go 76.33% <100.00%> (ø)
op-node/rollup/engine/events.go 100.00% <ø> (ø)
op-program/client/driver/program.go 77.14% <100.00%> (ø)
op-node/rollup/attributes/attributes.go 63.33% <66.66%> (ø)
op-node/rollup/driver/state.go 0.00% <0.00%> (ø)
op-program/client/driver/driver.go 25.00% <0.00%> (ø)

... and 1464 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joshklop joshklop force-pushed the joshklop/rm-pendingsaferequest branch 6 times, most recently from c4826c8 to df5c697 Compare August 19, 2025 19:49
@joshklop joshklop force-pushed the joshklop/rm-pendingsaferequest branch from df5c697 to c03786f Compare August 20, 2025 15:41
@joshklop joshklop added this pull request to the merge queue Aug 20, 2025
Merged via the queue into develop with commit f9e7aac Aug 20, 2025
68 checks passed
@joshklop joshklop deleted the joshklop/rm-pendingsaferequest branch August 20, 2025 16:37
leopoldjoy pushed a commit to leopoldjoy/optimism that referenced this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants