op-sync-tester: eth namespace relay#17117
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #17117 +/- ##
============================================
- Coverage 45.71% 8.23% -37.49%
============================================
Files 1478 3 -1475
Lines 119947 255 -119692
============================================
- Hits 54837 21 -54816
+ Misses 61263 234 -61029
+ Partials 3847 0 -3847
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
fa49d11 to
9feeef0
Compare
nonsense
approved these changes
Aug 20, 2025
leopoldjoy
pushed a commit
to leopoldjoy/optimism
that referenced
this pull request
Aug 22, 2025
* op-sync-tester: eth namespace relay * simplify * More synctester example configs * better error handling fore eth_chainId * safety guard * read only backend encapsulation * fix lint * rename * refactor sync tester init * mock rl backend and chainID test * refactor * GetBlockByHash tests * GetBlockByNumber tests * GetBlockReceipts tests * consistency * fix logic error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fully implement the eth namespace, validating with unit tests.
Adds
ReadOnlyELBackendinterface to wrap aroundethclient.Client, for ensuring we are calling only the read only rpcs and ease of testing.Sync Tester backend will access the EL through
ReadOnlyELBackend, and eth namespace APIs is used to craft the appropriate response.Generalized the Session state as
To hold the initial fcu state and the current fcu state. eth rpcs will use the current fcu state to decide to relay or not.
Block labels (latest, safe, finalized) is handled.
Tests
Unit test for
eth_getBlockReceipts,eth_getBlockByHash,eth_getBlockByNumberadded.Additional context
We need correctness of relay for both eth / engine namespace for proper sync. Worth to validate each namespace using unit tests, and this PR for eth.
Metadata