Skip to content

op-e2e: Delete TestCrossLayerUser#17106

Merged
mslipper merged 1 commit intodevelopfrom
feat/remove-crosslayeruser-test
Aug 18, 2025
Merged

op-e2e: Delete TestCrossLayerUser#17106
mslipper merged 1 commit intodevelopfrom
feat/remove-crosslayeruser-test

Conversation

@mslipper
Copy link
Collaborator

@mslipper mslipper commented Aug 18, 2025

Deletes TestCrossLayerUser. This is an action test that deposits, makes a transaction, then withdraws. It is our most flaky test by far:

Screenshot 2025-08-17 at 8 10 32 PM

I'm advocating for removing it because we have these tests covered in multiple other places:

  • The acceptance tests validate the full deposit/withdrawal flow
  • Deposits are validated implicitly by numerous E2E tests
  • Fault proofs have extensive unit tests that cover the proposal/game flow, as well as a dedicated E2E test

In sum, this test provides little value in return for failing often and slowing down our CI pipeline.

@mslipper mslipper requested review from a team as code owners August 18, 2025 02:09
@mslipper mslipper requested a review from teddyknox August 18, 2025 02:09
@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.37%. Comparing base (aa4db40) to head (2e78849).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17106      +/-   ##
===========================================
- Coverage    45.75%   42.37%   -3.38%     
===========================================
  Files         1478     1317     -161     
  Lines       119949   110709    -9240     
===========================================
- Hits         54877    46917    -7960     
+ Misses       61226    60108    -1118     
+ Partials      3846     3684     -162     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 175 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@pcw109550 pcw109550 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with mentioning that we may delete more codes like ActCompleteWithdrawal, ActCheckStartWithdrawal, ActStartWithdrawal, ActProveWithdrawal methods

@mslipper mslipper added this pull request to the merge queue Aug 18, 2025
Merged via the queue into develop with commit 2da6ec7 Aug 18, 2025
67 checks passed
@mslipper mslipper deleted the feat/remove-crosslayeruser-test branch August 18, 2025 18:59
leopoldjoy pushed a commit to leopoldjoy/optimism that referenced this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants