Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #17106 +/- ##
===========================================
- Coverage 45.75% 42.37% -3.38%
===========================================
Files 1478 1317 -161
Lines 119949 110709 -9240
===========================================
- Hits 54877 46917 -7960
+ Misses 61226 60108 -1118
+ Partials 3846 3684 -162
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
pcw109550
approved these changes
Aug 18, 2025
Member
pcw109550
left a comment
There was a problem hiding this comment.
Approving with mentioning that we may delete more codes like ActCompleteWithdrawal, ActCheckStartWithdrawal, ActStartWithdrawal, ActProveWithdrawal methods
janjakubnanista
pushed a commit
that referenced
this pull request
Aug 19, 2025
leopoldjoy
pushed a commit
to leopoldjoy/optimism
that referenced
this pull request
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes
TestCrossLayerUser. This is an action test that deposits, makes a transaction, then withdraws. It is our most flaky test by far:I'm advocating for removing it because we have these tests covered in multiple other places:
In sum, this test provides little value in return for failing often and slowing down our CI pipeline.