op-node: Remove TryUpdateEngine event#17096
Merged
Conversation
teddyknox
approved these changes
Aug 15, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #17096 +/- ##
===========================================
- Coverage 45.37% 44.54% -0.83%
===========================================
Files 1478 1423 -55
Lines 119990 115286 -4704
===========================================
- Hits 54444 51354 -3090
+ Misses 61718 60248 -1470
+ Partials 3828 3684 -144
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
janjakubnanista
pushed a commit
that referenced
this pull request
Aug 19, 2025
leopoldjoy
pushed a commit
to leopoldjoy/optimism
that referenced
this pull request
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
TryUpdateEngineevent. TheBuildStartedandEnvelopefields were never populated, so all of the metrics collection logic was unused. This made for a pretty clean refactor.I'll try the other
Try*family of events in a subsequent PR - I bet they'll be similar in scope.