Skip to content

Comments

op-node: Remove TryUpdateEngine event#17096

Merged
mslipper merged 1 commit intodevelopfrom
feat/remove-try-update-engine
Aug 15, 2025
Merged

op-node: Remove TryUpdateEngine event#17096
mslipper merged 1 commit intodevelopfrom
feat/remove-try-update-engine

Conversation

@mslipper
Copy link
Collaborator

@mslipper mslipper commented Aug 15, 2025

Removes the TryUpdateEngine event. The BuildStarted and Envelope fields were never populated, so all of the metrics collection logic was unused. This made for a pretty clean refactor.

I'll try the other Try* family of events in a subsequent PR - I bet they'll be similar in scope.

@mslipper mslipper requested review from a team as code owners August 15, 2025 19:50
@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 54.54545% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.54%. Comparing base (6683f1a) to head (f1c1421).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
op-node/rollup/engine/engine_controller.go 55.55% 5 Missing and 3 partials ⚠️
op-node/rollup/driver/state.go 0.00% 1 Missing ⚠️
op-node/rollup/engine/api.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17096      +/-   ##
===========================================
- Coverage    45.37%   44.54%   -0.83%     
===========================================
  Files         1478     1423      -55     
  Lines       119990   115286    -4704     
===========================================
- Hits         54444    51354    -3090     
+ Misses       61718    60248    -1470     
+ Partials      3828     3684     -144     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 96.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-node/rollup/driver/driver.go 0.00% <ø> (ø)
op-node/rollup/engine/events.go 96.07% <ø> (+37.83%) ⬆️
op-node/rollup/engine/payload_success.go 100.00% <100.00%> (+8.82%) ⬆️
op-node/rollup/driver/state.go 0.00% <0.00%> (ø)
op-node/rollup/engine/api.go 43.80% <0.00%> (ø)
op-node/rollup/engine/engine_controller.go 78.51% <55.55%> (+5.40%) ⬆️

... and 65 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mslipper mslipper added this pull request to the merge queue Aug 15, 2025
Merged via the queue into develop with commit 23b2cba Aug 15, 2025
67 checks passed
@mslipper mslipper deleted the feat/remove-try-update-engine branch August 15, 2025 20:55
leopoldjoy pushed a commit to leopoldjoy/optimism that referenced this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants