op-node: Refactor step scheduling events#17093
Merged
Conversation
teddyknox
approved these changes
Aug 15, 2025
Contributor
teddyknox
left a comment
There was a problem hiding this comment.
LGTM, if it passes tests.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #17093 +/- ##
===========================================
- Coverage 45.81% 44.58% -1.23%
===========================================
Files 1468 1413 -55
Lines 119406 114732 -4674
===========================================
- Hits 54707 51157 -3550
+ Misses 60862 59903 -959
+ Partials 3837 3672 -165
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
janjakubnanista
pushed a commit
that referenced
this pull request
Aug 19, 2025
leopoldjoy
pushed a commit
to leopoldjoy/optimism
that referenced
this pull request
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the following events by converting them into synchronous method calls:
StepReqEventResetStepBackoffEventStepDelayedReqEventI tried to refactor
StepEventas well, but ran into some issues with asynchrony in the action tests. I'll try that one again later.