Skip to content

Comments

op-node: Refactor step scheduling events#17093

Merged
mslipper merged 1 commit intodevelopfrom
feat/refactor-step-reqs
Aug 15, 2025
Merged

op-node: Refactor step scheduling events#17093
mslipper merged 1 commit intodevelopfrom
feat/refactor-step-reqs

Conversation

@mslipper
Copy link
Collaborator

@mslipper mslipper commented Aug 15, 2025

Refactors the following events by converting them into synchronous method calls:

  • StepReqEvent
  • ResetStepBackoffEvent
  • StepDelayedReqEvent

I tried to refactor StepEvent as well, but ran into some issues with asynchrony in the action tests. I'll try that one again later.

@mslipper mslipper marked this pull request as ready for review August 15, 2025 18:49
@mslipper mslipper requested review from a team as code owners August 15, 2025 18:49
@mslipper mslipper requested a review from sebastianst August 15, 2025 18:49
Copy link
Contributor

@teddyknox teddyknox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if it passes tests.

@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 47.50000% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.58%. Comparing base (b200250) to head (f52f54b).
⚠️ Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
op-node/rollup/driver/state.go 0.00% 12 Missing ⚠️
op-node/rollup/driver/steps.go 79.16% 4 Missing and 1 partial ⚠️
op-node/rollup/driver/driver.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17093      +/-   ##
===========================================
- Coverage    45.81%   44.58%   -1.23%     
===========================================
  Files         1468     1413      -55     
  Lines       119406   114732    -4674     
===========================================
- Hits         54707    51157    -3550     
+ Misses       60862    59903     -959     
+ Partials      3837     3672     -165     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 96.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-node/rollup/driver/driver.go 0.00% <0.00%> (ø)
op-node/rollup/driver/steps.go 85.71% <79.16%> (+15.40%) ⬆️
op-node/rollup/driver/state.go 0.00% <0.00%> (ø)

... and 68 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mslipper mslipper added this pull request to the merge queue Aug 15, 2025
Merged via the queue into develop with commit 6683f1a Aug 15, 2025
67 checks passed
@mslipper mslipper deleted the feat/refactor-step-reqs branch August 15, 2025 19:24
leopoldjoy pushed a commit to leopoldjoy/optimism that referenced this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants