op-deployer: fix bootstrap implementations flags#17090
Merged
Conversation
bitwiseguy
force-pushed
the
ss/op-deployer-implementation-cfg
branch
from
300ba13 to
d6dfae0
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #17090 +/- ##
===========================================
- Coverage 45.82% 42.41% -3.42%
===========================================
Files 1467 1306 -161
Lines 119308 110071 -9237
===========================================
- Hits 54678 46690 -7988
+ Misses 60804 59716 -1088
+ Partials 3826 3665 -161
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mslipper
approved these changes
Aug 15, 2025
janjakubnanista
pushed a commit
that referenced
this pull request
Aug 19, 2025
* op-deployer: fix bootstrap implementations flags * updated bootstrap devdoc
leopoldjoy
pushed a commit
to leopoldjoy/optimism
that referenced
this pull request
Aug 22, 2025
…7090) * op-deployer: fix bootstrap implementations flags * updated bootstrap devdoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pr fixes a few bugs related to the following cli command:
op-deployer bootstrap implementations.Bugs:
challengeris now a required input, but was not a flag recognized bybootstrap implementationsbootstrap implementationsshould supportembeddedartifacts locator (same asbootstrap superchain) but it was producing the errorfailed to deploy implementations: invalid config for Implementations: artifacts locator must be specifiedwithout adding the code in this pr to process the artifacts-locator cli flagFollow-up work
Extend op-deployer integration tests so that they cover cli inputs instead of starting at the underlying library functions that are invoked after the cli flags are interpreted.