Skip to content

Comments

Add DA Footprint Limit Acceptance Test#17034

Closed
axelKingsley wants to merge 1 commit intodevelopfrom
test/calldataFootprint
Closed

Add DA Footprint Limit Acceptance Test#17034
axelKingsley wants to merge 1 commit intodevelopfrom
test/calldataFootprint

Conversation

@axelKingsley
Copy link
Contributor

@axelKingsley axelKingsley commented Aug 12, 2025

Draft.

Generates 60 simultaneous transactions with 120KB of data each.
Then, iterates over the chain and evaluates the gasUsed field of the block, as well as the accumulated gas and calldata of the transactions.

TODO:

  • Perhaps stop using the spammer pattern, and instead manually queue up the transactions (since this can be done inside a single block)
  • Add test asserts after the blocks are created
  • Integrate with the actual feature to confirm it works

wg.Add(1)
go func() {
defer wg.Done()
sendTx(t, eoaGroup[i], to, calldataSize)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now the mere presence of transactions, even with negligible calldata, is causing bad blocks and failure to include the tx. Not sure why, investigating this, but I assume it's an issue with the feature.

@codecov
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.03%. Comparing base (08477e9) to head (4432f01).
⚠️ Report is 170 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (08477e9) and HEAD (4432f01). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (08477e9) HEAD (4432f01)
contracts-bedrock-tests 4 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #17034       +/-   ##
============================================
- Coverage    81.49%   66.03%   -15.46%     
============================================
  Files          167       55      -112     
  Lines         9912     4785     -5127     
============================================
- Hits          8078     3160     -4918     
+ Misses        1690     1481      -209     
  Partials       144      144               
Flag Coverage Δ
cannon-go-tests-64 66.03% <ø> (ø)
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 112 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sebastianst sebastianst force-pushed the test/calldataFootprint branch from 2540261 to 5ac3f99 Compare August 29, 2025 18:58
@sebastianst sebastianst changed the title Add Calldata Footprint Test Draft Add DA Footprint Limnit Acceptance Test Draft Sep 11, 2025
@sebastianst sebastianst force-pushed the test/calldataFootprint branch from 5ac3f99 to 94e8abc Compare September 11, 2025 10:03
@sebastianst sebastianst changed the title Add DA Footprint Limnit Acceptance Test Draft Add DA Footprint Limit Acceptance Test Draft Sep 11, 2025
@sebastianst sebastianst changed the title Add DA Footprint Limit Acceptance Test Draft Add DA Footprint Limit Acceptance Test Sep 11, 2025
@sebastianst sebastianst force-pushed the test/calldataFootprint branch from 94e8abc to a1b972b Compare September 11, 2025 10:07
@sebastianst sebastianst force-pushed the test/calldataFootprint branch from a1b972b to d9496dd Compare September 11, 2025 10:15
@sebastianst sebastianst force-pushed the test/calldataFootprint branch from d9496dd to 4432f01 Compare September 11, 2025 10:42
@opgitgovernance opgitgovernance added the S-stale Status: Will be closed unless there is activity label Sep 26, 2025
@opgitgovernance
Copy link
Contributor

This pr has been automatically marked as stale and will be closed in 5 days if no updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-stale Status: Will be closed unless there is activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants