Skip to content

op-chain-ops: using reflect.TypeFor in std lib #16965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nonsense merged 1 commit into from
Aug 18, 2025
Merged

op-chain-ops: using reflect.TypeFor in std lib #16965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions op-chain-ops/script/precompile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ func hasTrailingError(argCount int, getType func(i int) reflect.Type) bool {
return false
}
lastTyp := getType(argCount - 1)
return lastTyp.Kind() == reflect.Interface && lastTyp.Implements(typeFor[error]())
return lastTyp.Kind() == reflect.Interface && lastTyp.Implements(reflect.TypeFor[error]())
}

// setupMethod takes a method definition, attached to selfVal,
Expand Down Expand Up @@ -356,9 +356,9 @@ func goTypeToABIType(typ reflect.Type) (abi.Type, error) {
// since big.Int interpretation defaults to uint256.
type ABIInt256 big.Int

var abiInt256Type = typeFor[ABIInt256]()
var abiInt256Type = reflect.TypeFor[ABIInt256]()

var abiUint256Type = typeFor[uint256.Int]()
var abiUint256Type = reflect.TypeFor[uint256.Int]()

// goTypeToSolidityType converts a Go type to the solidity ABI type definition.
// The "internalType" is a quirk of the Geth ABI utils, for nested structures.
Expand Down Expand Up @@ -408,7 +408,7 @@ func goTypeToSolidityType(typ reflect.Type) (typeDef, internalType string, err e
if typ.AssignableTo(abiInt256Type) {
return "int256", "", nil
}
if typ.ConvertibleTo(typeFor[big.Int]()) {
if typ.ConvertibleTo(reflect.TypeFor[big.Int]()) {
return "uint256", "", nil
}
// We can parse into abi.TupleTy in the future, if necessary
Expand Down Expand Up @@ -643,9 +643,3 @@ func encodeRevert(outErr error) ([]byte, error) {
out = append(out, rightPad32(outErrStr)...) // the error message string
return out, vm.ErrExecutionReverted // Geth EVM will pick this up as a revert with return-data
}

// typeFor returns the [Type] that represents the type argument T.
// Note: not available yet in Go 1.21, but part of std-lib later.
func typeFor[T any]() reflect.Type {
return reflect.TypeOf((*T)(nil)).Elem()
}