Skip to content

op-challenger: Ensure mocked claims have non-negative clocks#16882

Merged
Inphi merged 1 commit intodevelopfrom
inphi/clocks
Jul 29, 2025
Merged

op-challenger: Ensure mocked claims have non-negative clocks#16882
Inphi merged 1 commit intodevelopfrom
inphi/clocks

Conversation

@Inphi
Copy link
Copy Markdown
Contributor

@Inphi Inphi commented Jul 29, 2025

A negative clock value prevents a recent version of upstream geth's abi package from decoding mocked claims. In Go, zero-valued time.Time values predates the year 1970, which results in a negative value when converted to a Unix timestamp.

This patch is done in anticipation of an update to the op-geth dependency that breaks this test.

@Inphi Inphi requested review from a team as code owners July 29, 2025 14:55
@Inphi Inphi requested review from jtriley2p and protolambda July 29, 2025 14:55
@Inphi Inphi enabled auto-merge July 29, 2025 14:56
@Inphi Inphi added this pull request to the merge queue Jul 29, 2025
Merged via the queue into develop with commit 987fb08 Jul 29, 2025
62 of 63 checks passed
@Inphi Inphi deleted the inphi/clocks branch July 29, 2025 15:23
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.27%. Comparing base (23db42a) to head (1fc57bb).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #16882       +/-   ##
============================================
+ Coverage    45.55%   82.27%   +36.71%     
============================================
  Files         1454      161     -1293     
  Lines       118595     9083   -109512     
============================================
- Hits         54028     7473    -46555     
+ Misses       60776     1469    -59307     
+ Partials      3791      141     -3650     
Flag Coverage Δ
cannon-go-tests-64 67.97% <ø> (-0.76%) ⬇️
contracts-bedrock-tests 96.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1298 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants