-
Notifications
You must be signed in to change notification settings - Fork 3.9k
feat: introduce configurable min basefee #16852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
03a16d9
min-base-fee solidity diffs
wlawt aecffb7
Update packages/contracts-bedrock/src/L1/SystemConfig.sol
geoknee 2106199
just pre-pr
geoknee 7aa2197
Merge remote-tracking branch 'origin/develop' into cmb-solidity
geoknee 7c6a2cb
just pre-pr
geoknee 1fc98bb
remove codegen bin
wlawt 0206db0
update semver and remove some more diffs in systemconfig codegen
wlawt 7e8743c
revert bindings/systemconfig
wlawt 898a311
bump OPCM systemconfigversion
wlawt 1bde28f
spike
wlawt d72ac6b
use my geth
wlawt 36b6151
claude first pass
wlawt fa7f163
claude second pass
wlawt 3deaac7
op-e2e/bindings abigen l1block and systemconfig
wlawt 7cd0147
update derivation pipeline
wlawt 12c21ff
rm forge artifacts
wlawt fb209bb
cleanup
wlawt 4e67590
fix casing and re-codegen
wlawt 154e8a2
fix comment
wlawt 8630d58
zero default
wlawt 5ae05bb
l1block not needed
wlawt 54770f9
reduce unnecessary usage of minbasefee
wlawt 8531913
add back setMinBaseFeeLog2
wlawt 241f258
undo codegen for l1block
wlawt 136294a
use 8bytes
wlawt 609aaed
update bindings/systemconfig and nits
wlawt ca0f1f7
nits
wlawt ba2fa42
best effort decode + nits
wlawt 2e17def
spike for more jovian
wlawt eb9f156
fix user_test
wlawt ee8762c
add jovian fork and activation test
wlawt 0827e86
wip - add acceptance test
wlawt ea0f7e9
gofmt + add op-e2e for minBaseFee + emit update for SystemConfig + fi…
wlawt 0b573dd
use feature flags
wlawt 6a647cb
feedback on e2e and acceptance tests
wlawt 1ad26f1
kurtosis fix test
wlawt 8d1cbe2
Switch from log2 to significand + exponent for min base fee
niran ed28283
Remove unnecessary type cast
niran 4226742
Rewrite tests to work with sysgo and correct the logic for testing w/…
niran cfb7569
Rename test
niran 743b9ad
Extract testing utilities into dsl functions like the operator fee tests
niran 48d2b44
Bump op-geth to the latest version where the tests pass
niran 9d311f3
Use u64 approach (#12)
wlawt c448ee8
feedback on contracts + remove diff on derive
wlawt fbfb146
fix ci
wlawt 4b2a48c
remove bindings and solidity diffs
wlawt 0389332
use ActivateForkAtOffset
wlawt 0666c5f
restore to develop due to merge conflict errors + remove op-e2e/syste…
wlawt 710bfc1
remove TestJovianInvalidPayload
wlawt bbbf464
jovian_action_test feedback
wlawt ec9db14
remove unused code/funcs in l2_sequencer and verifier
wlawt 3ccc15f
move & combine TestJovianActivationAtGenesis to actions/proofs
wlawt 8d7b427
devstack/acceptance test feedback
wlawt 4749b16
move mbf dsl into test file
wlawt 0a0052a
update kurtosis images
wlawt c26607e
reduce diffs
wlawt df671ce
merge cmb-solidity
wlawt be98d00
add acceptance-test.yaml to get kurtosis to run
wlawt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| optimism_package: | ||
| faucet: | ||
| enabled: true | ||
| image: {{ localDockerImage "op-faucet" }} | ||
| chains: | ||
| op-kurtosis: | ||
| participants: | ||
| node0: | ||
| el: | ||
| type: op-geth | ||
| image: "us-docker.pkg.dev/oplabs-tools-artifacts/images/op-geth:v1.101602.1-rc.1" | ||
| log_level: "" | ||
| extra_env_vars: {} | ||
| extra_labels: {} | ||
| extra_params: [] | ||
| tolerations: [] | ||
| volume_size: 0 | ||
| min_cpu: 0 | ||
| max_cpu: 0 | ||
| min_mem: 0 | ||
| max_mem: 0 | ||
| cl: &x-node-cl | ||
| type: op-node | ||
| image: {{ localDockerImage "op-node" }} | ||
| log_level: "" | ||
| extra_env_vars: {} | ||
| extra_labels: {} | ||
| extra_params: [] | ||
| tolerations: [] | ||
| volume_size: 0 | ||
| min_cpu: 0 | ||
| max_cpu: 0 | ||
| min_mem: 0 | ||
| max_mem: 0 | ||
| node1: | ||
| el: | ||
| type: op-reth | ||
| image: "ghcr.io/paradigmxyz/op-reth@sha256:7d83174c900a623897d5cf3a42764f19047ca47034f9726f5a9fad2c7ed32fee" | ||
| log_level: "" | ||
| extra_env_vars: {} | ||
| extra_labels: {} | ||
| extra_params: [] | ||
| tolerations: [] | ||
| volume_size: 0 | ||
| min_cpu: 0 | ||
| max_cpu: 0 | ||
| min_mem: 0 | ||
| max_mem: 0 | ||
| cl: *x-node-cl | ||
| network_params: | ||
| network: "kurtosis" | ||
| network_id: "2151908" | ||
| seconds_per_slot: 2 | ||
| fjord_time_offset: 0 | ||
| granite_time_offset: 0 | ||
| holocene_time_offset: 0 | ||
| isthmus_time_offset: 0 | ||
| jovian_time_offset: 60 | ||
| fund_dev_accounts: true | ||
| batcher_params: | ||
| image: {{ localDockerImage "op-batcher" }} | ||
| extra_params: [] | ||
| proposer_params: | ||
| image: {{ localDockerImage "op-proposer" }} | ||
| extra_params: [] | ||
| game_type: 1 | ||
| proposal_interval: 10m | ||
| challengers: | ||
| challenger: | ||
| enabled: true | ||
| image: {{ localDockerImage "op-challenger" }} | ||
| participants: "*" | ||
| cannon_prestates_url: {{ localPrestate.URL }} | ||
| cannon_trace_types: ["cannon", "permissioned"] | ||
| op_contract_deployer_params: | ||
| image: {{ localDockerImage "op-deployer" }} | ||
| l1_artifacts_locator: {{ localContractArtifacts "l1" }} | ||
| l2_artifacts_locator: {{ localContractArtifacts "l2" }} | ||
| overrides: | ||
| faultGameAbsolutePrestate: {{ localPrestate.Hashes.prestate_mt64 }} | ||
| global_log_level: "info" | ||
| global_node_selectors: {} | ||
| global_tolerations: [] | ||
| persistent: false | ||
| ethereum_package: | ||
| participants: | ||
| - el_type: geth | ||
| cl_type: teku | ||
| network_params: | ||
| preset: minimal | ||
| genesis_delay: 5 | ||
| additional_preloaded_contracts: | | ||
| { | ||
| "0x4e59b44847b379578588920cA78FbF26c0B4956C": { | ||
| "balance": "0ETH", | ||
| "code": "0x7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe03601600081602082378035828234f58015156039578182fd5b8082525050506014600cf3", | ||
| "storage": {}, | ||
| "nonce": "1" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package jovian | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/ethereum-optimism/optimism/op-devstack/presets" | ||
| ) | ||
|
|
||
| func TestMain(m *testing.M) { | ||
| presets.DoMain(m, presets.WithMinimal(), presets.WithJovianAtGenesis()) | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this kurtosis-devnet file at all? @janjakubnanista , should we expect a new yaml for every hardfork? I don't really see a big difference between this one and others.