Skip to content

Comments

fix(kt-devnet): use dash as network separator#16455

Merged
sigma merged 1 commit intodevelopfrom
sigma/kt-network-label
Jun 16, 2025
Merged

fix(kt-devnet): use dash as network separator#16455
sigma merged 1 commit intodevelopfrom
sigma/kt-network-label

Conversation

@sigma
Copy link
Contributor

@sigma sigma commented Jun 16, 2025

Description

This follow ethpandaops/optimism-package#337
Kurtosis labels are unfortunately limited in the characters they can use.

Tests

Additional context

Metadata

@sigma sigma requested a review from a team as a code owner June 16, 2025 20:36
@sigma sigma requested a review from mbaxter June 16, 2025 20:36
@sigma sigma enabled auto-merge June 16, 2025 20:37
@sigma sigma added this pull request to the merge queue Jun 16, 2025
Merged via the queue into develop with commit 57931bf Jun 16, 2025
59 of 60 checks passed
@sigma sigma deleted the sigma/kt-network-label branch June 16, 2025 21:05
@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.95%. Comparing base (1809039) to head (832677b).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #16455      +/-   ##
===========================================
- Coverage    46.97%   43.95%   -3.02%     
===========================================
  Files         1394     1233     -161     
  Lines       112732   103849    -8883     
===========================================
- Hits         52957    45651    -7306     
+ Misses       56047    54607    -1440     
+ Partials      3728     3591     -137     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
kurtosis-devnet/pkg/kurtosis/endpoints.go 92.55% <100.00%> (ø)

... and 167 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

iquidus pushed a commit to Layr-Labs/optimism that referenced this pull request Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants