Skip to content

Comments

op-node: Add dependency set flag#16094

Merged
protolambda merged 2 commits intodevelopfrom
aj/op-node-depset
May 23, 2025
Merged

op-node: Add dependency set flag#16094
protolambda merged 2 commits intodevelopfrom
aj/op-node-depset

Conversation

@ajsutton
Copy link
Contributor

Description

Adds a dependency-set CLI flag to op-node. Currently it is completely optional and unused other than being added to the node Config.

This PR is really just to unblock updating the kurtosis optimism-package so it can set the depset before landing other parts of #16042 which will actually start using it and make it a required arg when interop fork is scheduled.

Metadata

#16041

Required when interop fork is scheduled.
Makes the dependency set available on the node config but it isn't currently used.
Will unblock updating kurtosis to provide the depset config file.
@ajsutton ajsutton requested review from a team as code owners May 23, 2025 03:27
@ajsutton ajsutton requested a review from sebastianst May 23, 2025 03:27
@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (7eec6eb) to head (2ad3563).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #16094       +/-   ##
============================================
+ Coverage    82.39%   96.24%   +13.84%     
============================================
  Files          181      106       -75     
  Lines        10519     4575     -5944     
============================================
- Hits          8667     4403     -4264     
+ Misses        1699      172     -1527     
+ Partials       153        0      -153     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 96.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 75 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sebastianst added a commit to ethpandaops/optimism-package that referenced this pull request May 23, 2025
sebastianst added a commit to ethpandaops/optimism-package that referenced this pull request May 23, 2025
@protolambda protolambda enabled auto-merge May 23, 2025 14:09
@protolambda protolambda added this pull request to the merge queue May 23, 2025
auto-merge was automatically disabled May 23, 2025 14:21

Pull Request is not mergeable

Merged via the queue into develop with commit 8145253 May 23, 2025
59 checks passed
@protolambda protolambda deleted the aj/op-node-depset branch May 23, 2025 14:32
sebastianst added a commit to ethpandaops/optimism-package that referenced this pull request May 27, 2025
janjakubnanista pushed a commit to ethpandaops/optimism-package that referenced this pull request May 27, 2025
janjakubnanista pushed a commit to ethpandaops/optimism-package that referenced this pull request May 27, 2025
sebastianst added a commit to ethpandaops/optimism-package that referenced this pull request May 27, 2025
Consequence of ethereum-optimism/optimism#16094

---------

Co-authored-by: Ján Jakub Naništa <jan.jakub.nanista@gmail.com>
janjakubnanista added a commit to ethpandaops/optimism-package that referenced this pull request May 27, 2025
Consequence of ethereum-optimism/optimism#16094

---------

Co-authored-by: Ján Jakub Naništa <jan.jakub.nanista@gmail.com>
iquidus pushed a commit to Layr-Labs/optimism that referenced this pull request Jul 24, 2025
* op-node: Add dependency set flag

Required when interop fork is scheduled.
Makes the dependency set available on the node config but it isn't currently used.
Will unblock updating kurtosis to provide the depset config file.

* op-node: categorize the dependency set CLI flag

---------

Co-authored-by: protolambda <proto@protolambda.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants