Skip to content

Comments

feat(devstack): add minimal preset#15842

Merged
sigma merged 1 commit intodevelopfrom
sigma/minimal-preset
May 16, 2025
Merged

feat(devstack): add minimal preset#15842
sigma merged 1 commit intodevelopfrom
sigma/minimal-preset

Conversation

@sigma
Copy link
Contributor

@sigma sigma commented May 12, 2025

Description

This adds a lightweight preset for sanity checks.
This will be used by basic acceptance tests.

Tests

Additional context

Metadata

@sigma sigma requested review from a team as code owners May 12, 2025 15:04
@sigma sigma requested a review from protolambda May 12, 2025 15:04
@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.42%. Comparing base (38a0210) to head (3097bac).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #15842   +/-   ##
========================================
  Coverage    81.42%   81.42%           
========================================
  Files          161      161           
  Lines         8822     8822           
========================================
  Hits          7183     7183           
  Misses        1506     1506           
  Partials       133      133           
Flag Coverage Δ
cannon-go-tests-64 65.37% <ø> (ø)
contracts-bedrock-tests 96.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@pcw109550 pcw109550 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that the single L2CL is initialized by using the interop config, by default it would be in managed mode. The L2CL must be connected to the supervisor in managed mode to advance its heads.

So I think we need a supervisor for the minimal preset, and It would be nice to add basic unit test for confirming that L2CL is advancing in this settting.

@sigma sigma force-pushed the sigma/minimal-preset branch 3 times, most recently from e207a32 to 2011666 Compare May 14, 2025 16:28
@sigma
Copy link
Contributor Author

sigma commented May 14, 2025

I guess that the single L2CL is initialized by using the interop config, by default it would be in managed mode. The L2CL must be connected to the supervisor in managed mode to advance its heads.

So I think we need a supervisor for the minimal preset, and It would be nice to add basic unit test for confirming that L2CL is advancing in this settting.

Hmm, are you sure about this?
I mean, my goal was to model a non-interop system here, so it'd be disappointing to have to add a supervisor.

And it seems that L2CL is advancing fine without it. Can you take a look at the test I added for that?

@sigma sigma force-pushed the sigma/minimal-preset branch 3 times, most recently from 586cdd9 to d156e4b Compare May 14, 2025 16:44
@sigma sigma force-pushed the sigma/minimal-preset branch 2 times, most recently from 77ce1d1 to 296d7a7 Compare May 15, 2025 17:44
@sigma sigma added this pull request to the merge queue May 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2025
@sigma sigma force-pushed the sigma/minimal-preset branch from 296d7a7 to a5f5bea Compare May 16, 2025 14:49
This adds a lightweight preset for sanity checks.
This will be used by basic acceptance tests.
@sigma sigma force-pushed the sigma/minimal-preset branch from a5f5bea to 3097bac Compare May 16, 2025 17:29
@sigma sigma added this pull request to the merge queue May 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2025
@sigma sigma added this pull request to the merge queue May 16, 2025
Merged via the queue into develop with commit 976f872 May 16, 2025
59 checks passed
@sigma sigma deleted the sigma/minimal-preset branch May 16, 2025 19:52
iquidus pushed a commit to Layr-Labs/optimism that referenced this pull request Jul 24, 2025
This adds a lightweight preset for sanity checks.
This will be used by basic acceptance tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants