Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15842 +/- ##
========================================
Coverage 81.42% 81.42%
========================================
Files 161 161
Lines 8822 8822
========================================
Hits 7183 7183
Misses 1506 1506
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
I guess that the single L2CL is initialized by using the interop config, by default it would be in managed mode. The L2CL must be connected to the supervisor in managed mode to advance its heads.
So I think we need a supervisor for the minimal preset, and It would be nice to add basic unit test for confirming that L2CL is advancing in this settting.
e207a32 to
2011666
Compare
Hmm, are you sure about this? And it seems that L2CL is advancing fine without it. Can you take a look at the test I added for that? |
586cdd9 to
d156e4b
Compare
77ce1d1 to
296d7a7
Compare
296d7a7 to
a5f5bea
Compare
This adds a lightweight preset for sanity checks. This will be used by basic acceptance tests.
a5f5bea to
3097bac
Compare
This adds a lightweight preset for sanity checks. This will be used by basic acceptance tests.
Description
This adds a lightweight preset for sanity checks.
This will be used by basic acceptance tests.
Tests
Additional context
Metadata