fix(kt-devnet): rewrite endpoints parsing logic#15832
Merged
sigma merged 3 commits intosigma/multi-supervisor-2from May 12, 2025
Merged
fix(kt-devnet): rewrite endpoints parsing logic#15832sigma merged 3 commits intosigma/multi-supervisor-2from
sigma merged 3 commits intosigma/multi-supervisor-2from
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## sigma/multi-supervisor-2 #15832 +/- ##
=============================================================
- Coverage 88.98% 43.73% -45.25%
=============================================================
Files 17 1176 +1159
Lines 1552 99389 +97837
=============================================================
+ Hits 1381 43469 +42088
- Misses 153 52453 +52300
- Partials 18 3467 +3449
🚀 New features to boost your workflow:
|
sigma
force-pushed
the
sigma/multi-supervisor-2
branch
from
6e8ffa4 to
7eb3064
Compare
The previous approach was becoming unsustainable, and increasingly brittle. As we are changing the shape of naming conventions in optimism-package, use a pluggable approach instead, where each service type can have its own parsing logic associated to it.
sigma
force-pushed
the
sigma/multi-supervisor-3
branch
from
c5b55ce to
266c85d
Compare
|
|
||
| type triagedService struct { | ||
| tag string // service tag | ||
| idx int // service index (for nodes) |
Contributor
There was a problem hiding this comment.
In near future I am thinking of redoing the L2 participants to look like challengers or superchains or supervisors:
participants:
node0:
el:
image: ...
cl:
image: ...WDYT?
Contributor
Author
There was a problem hiding this comment.
sounds good to me. Hopefully we can introduce label-based metadata by then, so that it becomes transparent from here.
fix(kt-devnet): adjust devnet definitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This nukes the old brittle parsing logic for kurtosis devnet
endpoints, and supports the new formats in optimism-package.
Tests
Additional context
Metadata