Skip to content

op-conductor: add warn log when miner proxy call fails #15747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geoknee merged 1 commit into from
May 7, 2025
Merged

op-conductor: add warn log when miner proxy call fails #15747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion op-conductor/rpc/excecution_miner_proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (

var ExecutionMinerRPCNamespace = "miner"

// ExecutionMinerProxyBackend implements an execution rpc proxy with a leadership check before each call.
// ExecutionMinerProxyBackend implements an execution rpc proxy.
type ExecutionMinerProxyBackend struct {
log log.Logger
con conductor
Expand All @@ -31,6 +31,7 @@ func (api *ExecutionMinerProxyBackend) SetMaxDASize(ctx context.Context, maxTxSi
var result bool
err := api.client.Client().Call(&result, "miner_setMaxDASize", maxTxSize, maxBlockSize)
if err != nil {
api.log.Warn("proxy miner_setMaxDASize call failed", "err", err)
return false
}
return result
Expand Down