Skip to content

Panic on Failed to Enqueue #15740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
axelKingsley merged 1 commit into from
May 8, 2025
Merged

Panic on Failed to Enqueue #15740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion op-node/rollup/event/system.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,11 @@ func (s *Sys) emit(name string, derivContext uint64, ev Event) {
s.recordEmit(name, annotated, derivContext, emitTime)

err := s.executor.Enqueue(annotated)
// If the event system cannot enqueue an event, then it is a critical error
// and we should panic to avoid deferred errors creating behaviors that are hard to reason about.
// The Sys cannot decide if an event is important or not, so all events should be considered critical.
if err != nil {
s.log.Error("Failed to enqueue event", "emitter", name, "event", ev, "context", derivContext)
return
panic(err)
}
}