Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15697 +/- ##
===========================================
- Coverage 46.19% 42.96% -3.24%
===========================================
Files 1282 1121 -161
Lines 105545 96752 -8793
===========================================
- Hits 48758 41570 -7188
+ Misses 53271 51802 -1469
+ Partials 3516 3380 -136
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
sigma
added a commit
to ethpandaops/optimism-package
that referenced
this pull request
May 5, 2025
This change adds a concept of registry for the various container images we handle. It has several purposes: - to centralize the definition of the container images we use - to make it overridable by a downstream consumer In particular, this improves the reprodicibility capabilities of the package, as said downstream consumers can pin specific versions of the packages being used, in a way that's orthogonal to the arguments definition that's passed to the package. See ethereum-optimism/optimism#15697 for an example. The *defaults* are pinned, without affecting the ability to override images on a per-component instance basis.
opgitgovernance
added
the
S-stale
Contributor
|
This pr has been automatically marked as stale and will be closed in 5 days if no updates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WIP. This is to demo a new optimism-package feature to allow pinning container images from the caller.
Tests
Additional context
Metadata