refactor(test): improve L1ERC721Bridge test structure and documentation#15596
Closed
aliersh wants to merge 1 commit intoethereum-optimism:developfrom
Closed
refactor(test): improve L1ERC721Bridge test structure and documentation#15596aliersh wants to merge 1 commit intoethereum-optimism:developfrom
aliersh wants to merge 1 commit intoethereum-optimism:developfrom
Conversation
Contributor
aliersh
commented
Apr 28, 2025
aliersh
commented
- Group all tests by their corresponding contract functions
- Rename test to test_finalizeBridgeERC721_paused_reverts for consistency
- Move test_finalizeBridgeERC721_paused_reverts to L1ERC721Bridge_finalizeBridgeERC721_Test
- Convert @dev to @notice tags where appropriate
- Enforce 100 character line length limit for comments
…ation - Group all tests by their corresponding contract functions - Rename test to test_finalizeBridgeERC721_paused_reverts for consistency - Move test_finalizeBridgeERC721_paused_reverts to L1ERC721Bridge_finalizeBridgeERC721_Test - Convert @dev to @notice tags where appropriate - Enforce 100 character line length limit for comments
Contributor
Author
|
Some considerations:
|
aliersh
changed the title
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+242
to
+243
| /// @dev AD: This contract should be in a universal ERC721Bridge test file. | ||
|
|
Contributor
There was a problem hiding this comment.
This comment appears to be a personal note that should be removed or properly documented. If it's meant to indicate that the L1ERC721Bridge_Test contract should be moved to a universal test file, consider converting this to a proper @notice tag as per the PR's goal of converting @dev tags to @notice where appropriate.
Suggested change
| /// @dev AD: This contract should be in a universal ERC721Bridge test file. | |
| /// @dev This contract should be in a universal ERC721Bridge test file. |
Spotted by Diamond (based on custom rules)
Is this helpful? React 👍 or 👎 to let us know.
Contributor
Author
|
Replaced by #15735. Rebuilt from latest develop for cleaner diff and easier review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.