go: Update op-geth to v1.101507.0, based on geth v1.15.7#15587
Closed
sebastianst wants to merge 3 commits into
Closed
go: Update op-geth to v1.101507.0, based on geth v1.15.7#15587sebastianst wants to merge 3 commits into
sebastianst wants to merge 3 commits into
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15587 +/- ##
============================================
+ Coverage 46.82% 81.21% +34.38%
============================================
Files 1336 161 -1175
Lines 107829 8756 -99073
============================================
- Hits 50495 7111 -43384
+ Misses 53728 1512 -52216
+ Partials 3606 133 -3473
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
sebastianst
force-pushed
the
seb/geth-v1.15.7
branch
2 times, most recently
from
772e220 to
c349c03
Compare
sebastianst
force-pushed
the
seb/geth-v1.15.7
branch
from
c349c03 to
491d25f
Compare
sebastianst
force-pushed
the
seb/geth-v1.15.7
branch
from
284286e to
8f7bde7
Compare
sebastianst
force-pushed
the
seb/geth-v1.15.7
branch
from
8f7bde7 to
103b5c4
Compare
sebastianst
force-pushed
the
seb/geth-v1.15.7
branch
3 times, most recently
from
03f95d2 to
f2c9300
Compare
sebastianst
force-pushed
the
seb/geth-v1.15.7
branch
from
7320a84 to
09aa567
Compare
sebastianst
force-pushed
the
seb/geth-v1.15.7
branch
from
09aa567 to
2bdaa8c
Compare
Member
Author
|
Contained in #15829 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates op-geth to v1.101507.0, based on geth v1.15.7 (ethereum-optimism/op-geth#571).
It also updates Go to 1.23 (toolchain pinned to 1.23.8), also in Docker and CI etc.
The majority of the reported large diff comes from f2c9300347d10f2f6433093747a3c7221c5964d0 which updates a Cannon compat report. It has been verified by @Inphi and doesn't need a review. The remaining diff is quite small and is mostly just updates to bump the Go version and a few adaptions to new APIs, notably, using
tx.From()to directly get a deposit tx's from address.There's a small group of failing tests
TestSystem4844E2E_{Calldata,{Single,Multi}Blob}that seem to have been caused by this(ethereum/go-ethereum#31638) upstream change, but these tests seem to have been fixed again by ethereum/go-ethereum#31638 which got in somewhere between geth v1.15.{8...10}. Since we probably want to merge the 1.15.10 (or even 1.15.11) changes right away, I suggest we don't try to fix the test in this PR, since the fix is just moving the geth version forward.Metadata
Closes ethereum-optimism/op-geth#559