Add Interop Upgrade Txs to op-node

[teddyknox]

Description

Adds interop upgrade txs in accordance to ethereum-optimism/specs#672

Necessary second-order changes:

• Update the op-chain-ops/interopgen test framework to support activating interop after network setup rather than at genesis.
• Adding ActBuildL2ToInterop() to L2Sequencer
• actors.PrepareChainState(t) has been renamed to actors.PrepareAndVerifyInitialState(t), and logic within that function has been factored into two new functions:
  • actors.PrepareChainState(t), which performs the preparation steps (adopting the previous name of actors.PrepareAndVerifyInitialState(t))
  • actors.VerifyInitialState(t), which verifies that the chain has been setup correctly assuming a genesis timestamp interop activation.
    This makes it possible to use the logic in the new actors.PrepareChainState(t) function without the verify step, which hardcodes the genesis timestamp activation assumption.

Tests

• Adds TestInteropUpgradeTransactions in op-e2e/actions/upgrades/interop_fork_test.go which verifies that the transactions match the spec.
• Adds TestInteropUpgradeTransactions in op-e2e/actions/upgrades/interop_fork_test.go which verifies that the upgrade transactions are applied appropriately.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.35%. Comparing base (92cb5cd) to head (ab7e3b0).
Report is 4 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop   #15517       +/-   ##
============================================
+ Coverage    46.10%   92.35%   +46.25%     
============================================
  Files         1281      122     -1159     
  Lines       105461     5850    -99611     
============================================
- Hits         48626     5403    -43223     
+ Misses       53332      435    -52897     
+ Partials      3503       12     -3491     

Flag	Coverage Δ
cannon-go-tests-64	?
contracts-bedrock-tests	95.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1162 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sebastianst]

It seems to match the specs (but using the correct updateTo call argument). But there's only so much we can verify statically. We need an end2end test of the transition block, ideally an actions/proof test, to verify that the upgrade transactions work as intended.

[geoknee]

Update all previous calls to VerifyInitialState() to also feature a call to actors.PrepareChainState(t).
Did you mean to say "update all calls to prepare with a call to verify"?
Tests

Adds TestInteropUpgradeTransactions in op-e2e/actions/upgrades/interop_fork_test.go which verifies that the transactions match the spec.
Adds TestInteropUpgradeTransactions in op-e2e/actions/upgrades/interop_fork_test.go which verifies that the upgrade transactions are applied appropriately.

Nit: this doesn't seem accurate. NBD but it can cause some confusion.

[teddyknox]

@geoknee thanks for the thorough review.

Nit: this doesn't seem accurate. NBD but it can cause some confusion.

I updated the description to be more accurate. Apologies, it had fallen out of date.

[sebastianst]

One critical check should be changed at the end of the action test, then we can merge it and work on remaining open discussions in the follow-up PR.

[sebastianst]

Approving and merging to get this in, but all open comments need to be addressed in a follow-up soon. I've resolved all open comments with the comment "TODO in follow-up".