Skip to content

Comments

kt-devnet: add op-faucet support#15516

Merged
sigma merged 1 commit intodevelopfrom
sigma/kt-op-faucet
Apr 24, 2025
Merged

kt-devnet: add op-faucet support#15516
sigma merged 1 commit intodevelopfrom
sigma/kt-op-faucet

Conversation

@sigma
Copy link
Contributor

@sigma sigma commented Apr 22, 2025

Description

This allows building op-faucet from local repo (only option for now,
until a proper release is cut), with a working example in the interop
devnet.

Tests

Additional context

Metadata

This allows building op-faucet from local repo (only option for now,
until a proper release is cut), with a working example in the interop
devnet.
@wiz-inc-a178a98b5d
Copy link

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities
Data Finding Sensitive Data
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations 1 High 1 Low
Total 1 High 1 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@sigma
Copy link
Contributor Author

sigma commented Apr 22, 2025

this should be merged only after #15515

@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.55%. Comparing base (de3a3e6) to head (d8f7b3b).
Report is 8 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (de3a3e6) and HEAD (d8f7b3b). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (de3a3e6) HEAD (d8f7b3b)
cannon-go-tests-32 3 0
cannon-go-tests-64 3 0
contracts-bedrock-tests 2 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15516       +/-   ##
============================================
- Coverage    46.78%    5.55%   -41.24%     
============================================
  Files         1277        4     -1273     
  Lines       105423       72   -105351     
============================================
- Hits         49323        4    -49319     
+ Misses       52626       66    -52560     
+ Partials      3474        2     -3472     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1276 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sigma sigma marked this pull request as ready for review April 22, 2025 21:51
@sigma sigma requested review from a team as code owners April 22, 2025 21:51
@sigma sigma requested review from jelias2 and mslipper April 22, 2025 21:51
@sigma sigma enabled auto-merge April 22, 2025 21:59
@sigma sigma added this pull request to the merge queue Apr 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 24, 2025
@sigma sigma added this pull request to the merge queue Apr 24, 2025
Merged via the queue into develop with commit 081c22d Apr 24, 2025
53 checks passed
@sigma sigma deleted the sigma/kt-op-faucet branch April 24, 2025 15:05
iquidus pushed a commit to Layr-Labs/optimism that referenced this pull request Jul 24, 2025
This allows building op-faucet from local repo (only option for now,
until a proper release is cut), with a working example in the interop
devnet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kt-devnet: add op-faucet

2 participants