Skip to content

Revert "cannon: Implement dclo|dclz (#14454)"#15367

Merged
sigma merged 1 commit intodevelopfrom
sigma/revert-14454
Apr 11, 2025
Merged

Revert "cannon: Implement dclo|dclz (#14454)"#15367
sigma merged 1 commit intodevelopfrom
sigma/revert-14454

Conversation

@sigma
Copy link
Contributor

@sigma sigma commented Apr 11, 2025

Description

This reverts commit d38b80e.

Tests

Additional context

Metadata

@sigma sigma requested review from a team as code owners April 11, 2025 18:49
@sigma sigma requested a review from ajsutton April 11, 2025 18:49
@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.36%. Comparing base (d38b80e) to head (af5ec33).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15367      +/-   ##
===========================================
- Coverage    46.37%   46.36%   -0.02%     
===========================================
  Files         1227     1227              
  Lines       103068   103054      -14     
===========================================
- Hits         47794    47776      -18     
- Misses       51910    51913       +3     
- Partials      3364     3365       +1     
Flag Coverage Δ
cannon-go-tests-32 61.99% <0.00%> (+0.09%) ⬆️
cannon-go-tests-64 57.04% <100.00%> (-0.13%) ⬇️
contracts-bedrock-tests 94.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cannon/mipsevm/exec/mips_instructions.go 97.45% <ø> (-0.05%) ⬇️
cannon/mipsevm/versions/version.go 80.00% <100.00%> (-1.49%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sigma sigma added this pull request to the merge queue Apr 11, 2025
Merged via the queue into develop with commit 03f8875 Apr 11, 2025
48 of 50 checks passed
@sigma sigma deleted the sigma/revert-14454 branch April 11, 2025 19:42
Inphi added a commit that referenced this pull request Apr 29, 2025
Inphi added a commit that referenced this pull request Apr 29, 2025
Inphi added a commit that referenced this pull request Apr 29, 2025
ClaytonNorthey92 pushed a commit to hemilabs/optimism that referenced this pull request May 13, 2025
iquidus pushed a commit to Layr-Labs/optimism that referenced this pull request Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants