Backports: fix(op-deployer): fix inspect and state types to respect unmarshalling the state.json (#14889)#14921
Closed
yashvardhan-kukreja wants to merge 1 commit intobackports/op-deployer/v0.0.13from
Conversation
…g the state.json (#14889) * fix(op-deployer): fix inspect and state types to respect unmarshalling the state.json Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co> * fix: add custom marshaller to eth.BlockRef Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co> * nit Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co> * chore: remove the custom serializer from blockref Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co> * chore: add unit tests for BlockRef's Serialize and Deserialise Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co> * clean up test * put marshaler inside start block * Revert "put marshaler inside start block" This reverts commit 46b5eaf. * Revert "clean up test" This reverts commit e196859. * Revert "chore: add unit tests for BlockRef's Serialize and Deserialise" This reverts commit d85ce6a. * Revert "chore: remove the custom serializer from blockref" This reverts commit 3dd0834. * Revert "fix: add custom marshaller to eth.BlockRef" This reverts commit fb4ff4a. * unit tests --------- Signed-off-by: Yashvardhan Kukreja <yashvardhan@oplabs.co> Co-authored-by: Matthew Slipper <me@matthewslipper.com>
Contributor
|
This pr has been automatically marked as stale and will be closed in 5 days if no updates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports the fix in op-deployer related to parsing and unmarshalling the state.json's startBlock section correctly to eth.BlockRef through an intermediate serializable type.
Source: #14889
Tests
Some manual testing by modifying the rollup.go to
With state.json
Parsed output is
With state.json
Parsed output is
Additional context
Metadata