Skip to content

fix(kurtosis-devnet): correct fallback for user socket #14907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pcw109550 wants to merge 2 commits into from
Closed

fix(kurtosis-devnet): correct fallback for user socket #14907

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c32a458
fix(kurtosis-devnet): correct fallback for user socket
pcw109550 Mar 17, 2025
27554b1
fetch proto's comments and diffs
pcw109550 Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions kurtosis-devnet/pkg/build/docker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,26 +56,32 @@ func (p *defaultDockerProvider) newClient() (dockerClient, error) {
opts := []client.Opt{client.FromEnv}

// Check if default docker socket exists
// See https://github.com/moby/moby/discussions/46015 :
// the ParseHostURL function does not technically support `unix`,
// and the non-scheme part just ends up in the `.Host` instead of `.Path`
hostURL, err := client.ParseHostURL(client.DefaultDockerHost)
if err != nil {
return nil, fmt.Errorf("failed to parse default docker host: %w", err)
}

// For unix sockets, check if the socket file exists
if hostURL.Scheme == "unix" {
if _, err := os.Stat(hostURL.Path); os.IsNotExist(err) {
if _, err := os.Stat(hostURL.Host); os.IsNotExist(err) {
// Default socket doesn't exist, try alternate location. Docker Desktop uses ~/.docker/run/docker.sock
// Docker Desktop uses ~/.docker/run/docker.sock
// or also ~/.docker/desktop/docker.sock
homeDir, err := os.UserHomeDir()
if err != nil {
return nil, fmt.Errorf("failed to get user home directory: %w", err)
}
homeSocketPath := fmt.Sprintf("%s/.docker/run/docker.sock", homeDir)
if _, err := os.Stat(homeSocketPath); os.IsNotExist(err) {
homeSocketHost := fmt.Sprintf("%s/.docker/run/docker.sock", homeDir)
if _, err := os.Stat(homeSocketHost); os.IsNotExist(err) {
return nil, errors.New("failed to find docker socket")
}
log.Printf("WARNING: using implied user docker socket: %q, make sure Kurtosis is running inside of the same docker context!", homeSocketHost)
socketURL := &url.URL{
Scheme: "unix",
Path: homeSocketPath,
Host: homeSocketHost,
}
// prepend the host, so that it can still be overridden by the environment.
opts = append([]client.Opt{client.WithHost(socketURL.String())}, opts...)
Expand Down