Skip to content

Enable NAT Tests in CI#14885

Merged
scharissis merged 4 commits intodevelopfrom
op-acceptor-ci
Mar 20, 2025
Merged

Enable NAT Tests in CI#14885
scharissis merged 4 commits intodevelopfrom
op-acceptor-ci

Conversation

@teddyknox
Copy link
Contributor

@teddyknox teddyknox commented Mar 14, 2025

Runs as part of the main CI workflow. Skips tests that do not pass validators, a later PR will disable this in combination with #14900 which will add more release-level gate configuration.

CI will fail until #14907 is merged.

@teddyknox teddyknox added the M-do-not-merge Meta: Do not merge label Mar 14, 2025
@teddyknox teddyknox requested review from a team as code owners March 14, 2025 20:18
@teddyknox teddyknox changed the title Enable Holocene NAT Tests in CI Enable NAT Tests in CI Mar 14, 2025
Copy link
Contributor

@janjakubnanista janjakubnanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions rather than remarks

@teddyknox teddyknox added the A-devnet-sdk Area: devnet-sdk label Mar 14, 2025
@teddyknox
Copy link
Contributor Author

/ci authorize c800da6

Copy link
Contributor

@scharissis scharissis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@codecov
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.44%. Comparing base (4dbde37) to head (155bd43).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14885      +/-   ##
===========================================
+ Coverage    46.39%   46.44%   +0.04%     
===========================================
  Files         1129     1129              
  Lines        98159    98159              
===========================================
+ Hits         45541    45590      +49     
+ Misses       49322    49278      -44     
+ Partials      3296     3291       -5     
Flag Coverage Δ
cannon-go-tests-32 62.08% <ø> (ø)
cannon-go-tests-64 57.13% <ø> (ø)
contracts-bedrock-tests 94.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@teddyknox teddyknox removed the M-do-not-merge Meta: Do not merge label Mar 14, 2025
@teddyknox teddyknox force-pushed the op-acceptor-ci branch 8 times, most recently from 989bd2f to 76b6633 Compare March 18, 2025 22:09
@scharissis scharissis added this pull request to the merge queue Mar 20, 2025
Merged via the queue into develop with commit 0cb4fb0 Mar 20, 2025
51 checks passed
@scharissis scharissis deleted the op-acceptor-ci branch March 20, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-devnet-sdk Area: devnet-sdk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments