Skip to content

op-node/rollup/derive: validate to field non-nil for setcode txs #14882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastianst merged 1 commit into from
Mar 14, 2025
Merged

op-node/rollup/derive: validate to field non-nil for setcode txs #14882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions op-node/rollup/derive/span_batch_tx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,10 @@ func (tx *spanBatchTx) convertToFullTx(nonce, gas uint64, to *common.Address, ch
S: S,
}
case types.SetCodeTxType:
if to == nil {
return nil, fmt.Errorf("to address is required for SetCodeTx")
}

setCodeTxInner := tx.inner.(*spanBatchSetCodeTxData)
inner = &types.SetCodeTx{
ChainID: uint256.MustFromBig(chainID),
Expand Down
8 changes: 8 additions & 0 deletions op-node/rollup/derive/span_batch_tx_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,3 +144,11 @@ func TestSpanBatchTxDecodeInvalid(t *testing.T) {
err = sbtx.UnmarshalBinary(invalidLegacyTxDecoded)
require.ErrorContains(t, err, "failed to decode spanBatchLegacyTxData")
}

func TestSpanBatchTxSetCodeInvalidTo(t *testing.T) {
// invalid to for setcode tx
var sbtx spanBatchTx
sbtx.inner = &spanBatchSetCodeTxData{}
_, err := sbtx.convertToFullTx(0, 0, nil, nil, nil, nil, nil)
require.ErrorContains(t, err, "to address is required for SetCodeTx")
}