Skip to content

Comments

op-deployer: Fix broken init logic backport v0.3.0#14828

Merged
mslipper merged 1 commit intobackports/op-deployer/v0.3.0from
bugfix/backport-intent-guardian-030
Mar 12, 2025
Merged

op-deployer: Fix broken init logic backport v0.3.0#14828
mslipper merged 1 commit intobackports/op-deployer/v0.3.0from
bugfix/backport-intent-guardian-030

Conversation

@mslipper
Copy link
Collaborator

@mslipper mslipper commented Mar 12, 2025

This PR backports commit 0085136.

Previously, any deployment using tagged releases on an official chain like Sepolia would use the predeployed OPCM. The predeployed OPCM would point these chains to the global SuperchainConfig, which may not have been the intended behavior. This PR updates the logic in the deployment pipeline to use the global SuperchainConfig under the following conditions:

  1. The user specifies intent type standard.
  2. The user specifies intent type standard-overrides and does not modify the Superchain roles.

Previously, any deployment using tagged releases on an official chain like Sepolia would use the predeployed OPCM. The predeployed OPCM would point these chains to the global `SuperchainConfig`, which may not have been the intended behavior. This PR updates the logic in the deployment pipeline to use the global `SuperchainConfig` under the following conditions:

1. The user specifies intent type `standard`.
2. The user specifies intent type `standard-overrides` and does not modify the Superchain roles.
@mslipper mslipper requested a review from a team as a code owner March 12, 2025 20:26
@mslipper mslipper requested review from geoknee and removed request for a team March 12, 2025 20:26
@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 61.70213% with 18 lines in your changes missing coverage. Please review.

Project coverage is 41.75%. Comparing base (1ef70a7) to head (6be24dd).
Report is 1 commits behind head on backports/op-deployer/v0.3.0.

Files with missing lines Patch % Lines
op-deployer/pkg/deployer/state/intent.go 43.75% 6 Missing and 3 partials ⚠️
op-deployer/pkg/deployer/pipeline/init.go 69.56% 5 Missing and 2 partials ⚠️
op-deployer/pkg/deployer/standard/standard.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##           backports/op-deployer/v0.3.0   #14828      +/-   ##
================================================================
- Coverage                         46.58%   41.75%   -4.83%     
================================================================
  Files                              1046      875     -171     
  Lines                             90573    80578    -9995     
================================================================
- Hits                              42195    33649    -8546     
+ Misses                            45248    43997    -1251     
+ Partials                           3130     2932     -198     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-deployer/pkg/deployer/standard/standard.go 44.14% <75.00%> (+2.39%) ⬆️
op-deployer/pkg/deployer/pipeline/init.go 39.78% <69.56%> (-5.57%) ⬇️
op-deployer/pkg/deployer/state/intent.go 53.55% <43.75%> (-2.17%) ⬇️

... and 188 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mslipper mslipper merged commit 060a261 into backports/op-deployer/v0.3.0 Mar 12, 2025
46 checks passed
@mslipper mslipper deleted the bugfix/backport-intent-guardian-030 branch March 12, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant