Sequencer Batch Submitter #148

K-Ho · 2020-06-05T14:49:19Z

Description

Helper contract that allows the sequencer to submit both a state commitment batch and tx batch in a single transaction. This is the contract that will be whitelisted for instant submission to the CanonicalTransactionChain.

NOTE: This PR builds off of #143

Fixes

Fixes #YAS-408

Contributing Agreement

I have read and understood the Optimism Contributing Guide and Code of Conduct and am following those guidelines in this pull request.

willmeister

LGTM 👍

Only suggestions are to add a bit more documentation as to how the contract is meant to fit into the bigger picture.

willmeister · 2020-06-05T19:45:28Z

packages/rollup-contracts/contracts/SequencerBatchSubmitter.sol

+import {CanonicalTransactionChain} from "./CanonicalTransactionChain.sol";
+import {StateCommitmentChain} from "./StateCommitmentChain.sol";
+
+contract SequencerBatchSubmitter {


Could you add some context comment as to what this is meant to do, who is meant to interact with it, etc.?

willmeister · 2020-06-05T19:47:15Z

packages/rollup-contracts/contracts/SequencerBatchSubmitter.sol

+    stateCommitmentChain = StateCommitmentChain(_stateCommitmentChain);
+  }
+
+  function appendTransitionBatch(


Could you add a bit about what the bytes of the _txBatch and _stateBatch represent? Is it just tx calldata? Is it signed transactions, how are they encoded, etc.?

willmeister · 2020-06-05T19:48:13Z

packages/rollup-contracts/contracts/SequencerBatchSubmitter.sol

+  modifier onlySequencer () {
+    require(msg.sender == sequencer, "Only the sequencer may perform this action");
+    _;
+  }


If there are other functions that should only be called by the sequencer, would move this into some utils lib. It's fine here for right now though 😄

willmeister · 2020-06-05T19:49:03Z

packages/rollup-contracts/test/rollup-list/SequencerBatchSubmitter.spec.ts

+      await TestUtils.assertRevertsAsync(
+        'Must append the same number of state roots and transactions',


willmeister · 2020-06-05T19:49:39Z

packages/rollup-contracts/test/rollup-list/SequencerBatchSubmitter.spec.ts

+
+  before(async () => {
+    rollupMerkleUtils = await deployContract(wallet, RollupMerkleUtils, [], {
+      gasLimit: 6700000,


might suggest making this a const

* Separates storage from SCC and CTC (#151) * First pass version * More minor tweaks for tests to pass * Add authentication * Minor config updates * Fix lint error * Fix naming changes per review * Enable Deployer Whitelist (#119) * first pass, test runner updated * add ability to only validate flag, test passes * all tests passing * clean up console.logs * enforce gas refund preservation * more cleanup/import removal * whitelisted -> allowed * first pass, test runner updated * add ability to only validate flag, test passes * all tests passing * clean up console.logs * enforce gas refund preservation * more cleanup/import removal * whitelisted -> allowed * remove whitespace * Restrict StateTransitionerFactory (#140) * added msg sender check * add create test * cleanup * add param * add addressmanager.address param * CTC Chain Monotonicity Fixes (#93) * [wip] Fix block time logic * some sad path and happy tests passing * more progress * first pass sad cases tested * cleanup, adding empty tests * more reversion tests * rename shouldstartat} * add final couple tests * enable more tests * cleanup * remove .only * textual cleanup * make queue length public * improve structure, comments * update deploy config * address nits Co-authored-by: Karl Floersch <[email protected]> * fix declarations, lint (#152) * Adds river's new Merkle tree implementation, with some cleanup (#148) * Reverts an accidental breaking merge * Added new merkle tree impl * add comments * Final cleanups and merge Co-authored-by: Ben Jones <[email protected]> * Fix run gas Lower Bound (#94) * added the check * add test * lower OVM TX size for Kovan * re-remove gas check * update gas vals slightly * lint * lint * Merge master into freeze integration branch (#153) * update solidity version to ^0.7.0 (#122) * update solc version to ^0.7.0 * interfaces back to solidity >0.6.0 <0.8.0 * update solc to 0.7.6 * back to 0.7.4 * upgrade to 0.7.6, fix EXTCODESIZE check * versions >0.5.0 <0.8.0 for xdomain msgers * ctc: disable appendQueueBatch (#150) * ctc: disable appendSequencerBatch * typo: fix * re-enable verifyQueueTransaction test: * add explicit test for verifying queue elements against either append Co-authored-by: Ben Jones <[email protected]> * fix up test * remove .only Co-authored-by: Alina <[email protected]> Co-authored-by: Mark Tyneway <[email protected]> * add check, simple test, update deploy (#154) * go back to first name (#155) * lint * fix js number error * add error logging to help debug deploy * [code freeze] Fix deploy script (#156) * fix deploy script * add block time config * ensure value is integer * lint * remove console logs from deploy * Moves gas check to applyTransaction (#161) * move to OVM_ST, pass test * remove old test because functionality moved * linting * remove leaf hasing * use safe EXEMRG wrapper (#162) * use safeREQUIRE * add owner getter * relayer: add to config (#160) * relayer: add to config * lint: fix * Fix minor error in test config Co-authored-by: Kelvin Fichter <[email protected]> Co-authored-by: ben-chain <[email protected]> Co-authored-by: Alina <[email protected]> Co-authored-by: Mark Tyneway <[email protected]> Co-authored-by: Kevin Ho <[email protected]>

* Initial script to play with celo DB history migration * Can Read All the headers Co-authored-by: Alec Schaefer <[email protected]> * Adds new command to migrate ancients db * Adds comment * Adds extension methods for transformation * Implements Transform CeloBody * Adds impl that runs steps in a concurrent pipeline * Adds transformHead, verify hashing works cleanup * add migration for non-frozen blocks * copy over entire db and modify in place, works with op-geth at piersy/minimal-data-migration * remove unecessary copying, cleanup code * close and reopen DBs * migrate newdb in place * saving progress Co-authored-by: Mariano Cortesi <[email protected]> * Refactor code to improve database migration process * better logging * refactor: inline parMigrateAncientRange * Remove frozen blocks from nonAncient DB * check hash matches on nonAncients migration * clean up branch Removes unused code, move code for better separation of concerns. * decode into new types * fix transformHeader * make old freezer not readonly so that .meta files are created * add configurable memory limit * add comment about memory * Added celo-dbmigrate Makefile target * Added dockerfile for celo-dbmigrate and celo-migrate tools * Workflow for running cel2-migration-tool * Update cel2-migration-tool image registry * update op-geth to point to https://github.com/celo-org/op-geth/commits/piersy/for-use-with-migrated-celo-datadir-use-gas-limit-differentiation-rebased-celo6/ * add celo6 logging * rename scripts to celo-migrate-state and celo-migrate-blocks * first pass at combining scripts * saving progress on testing * fix lint error, use %w to fmt errors * add updated state migration input files to testdata * add ability to run block and state migration seperately or together * add option for migrating only frozen blocks * remove old scripts * minor logging improvements in block migrations * invert clearNonAncients flag logic --> keepNonAncients, make dry-run flag only apply to state migration * adds README, improves logging * fix lint err * Fix Makefile and Dockerfile * move createNewDbIfNotExists * rename keep-non-ancients * update TODO to add more context and state changes * Remove channel buffers from ancients migration Co-authored-by: Valentin Rodygin <[email protected]> * bump default batch size to 100000 * add back extended usage string * add info on state migration to README * remove --state-dry-run flag * update default batch size to 50k * Adding building for op images * Setting our values for image registry and repository * update README * fix logging when newAncients > oldAncients * fix return value when skipping ancients * skip transforming block bodies that have already been transformed * misc. fixes to get re-runs with --keep-non-ancients working * adds TODO * addresses cosmetic feedback * add flag for specifying a buffer * Show progress on rsync * Update to latest op-geth * state-migration: Refactor subtask * state-migration: Use EIP1559 settings from deploy config Fixes celo-org#135 * state-migration: Enable Fjord hardfork during migration Fixes celo-org#160 * state-migration: Deterministicly set migration block timestamp Fixes celo-org#157 Sets the timestamp to be 5s after the last block. * state-migration: Set WithdrawalsHash in Cel2 migration block * fixup! Fix Makefile and Dockerfile * add note to README about using snapshots for pre-migration * Set blob gas header fields for transition block These are now required to be set since cancun was activated. * Use InitialBaseFee for pre-gingerbread transitionb * Fix warnings about capitalized error strings * Output chain config as marshalled JSON * state-migration: Handle accounts with existing balance Fixes celo-org#158 * remove allocs file, add instructions for how to generate allocs file to README, update TODOs --------- Co-authored-by: Mariano Cortesi <[email protected]> Co-authored-by: Alec Schaefer <[email protected]> Co-authored-by: Mariano Cortesi <[email protected]> Co-authored-by: Javier Cortejoso <[email protected]> Co-authored-by: Paul Lange <[email protected]> Co-authored-by: Valentin Rodygin <[email protected]> Co-authored-by: Piers Powlesland <[email protected]>

### Description Update codeowners to include [refcell](https://github.com/refcell) and [clabby](https://github.com/clabby)

K-Ho added 2 commits June 5, 2020 10:43

implement SequencerBatchSubmitter

d4a5b56

fix appendBatch name

3aef3f5

K-Ho mentioned this pull request Jun 5, 2020

Sequencer Batch Submitter #145

Closed

1 task

willmeister approved these changes Jun 5, 2020

View reviewed changes

add more comments

e43a003

K-Ho merged commit 1e10300 into master Jun 5, 2020

gakonst deleted the YAS-408/RollupChain/SequencerBatchSubmitter branch March 18, 2021 15:01

Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025

[SM2-04M] Improper Management of Pause States ethereum-optimism#148

78350d7

theochap pushed a commit that referenced this pull request Jan 15, 2026

feat: Codeowner Updates (#148)

382219f

### Description Update codeowners to include [refcell](https://github.com/refcell) and [clabby](https://github.com/clabby)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sequencer Batch Submitter #148

Sequencer Batch Submitter #148

Uh oh!

K-Ho commented Jun 5, 2020

Uh oh!

willmeister left a comment

Uh oh!

willmeister Jun 5, 2020

Uh oh!

willmeister Jun 5, 2020

Uh oh!

willmeister Jun 5, 2020

Uh oh!

willmeister Jun 5, 2020

Uh oh!

willmeister Jun 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		await TestUtils.assertRevertsAsync(
		'Must append the same number of state roots and transactions',

Sequencer Batch Submitter #148

Sequencer Batch Submitter #148

Uh oh!

Conversation

K-Ho commented Jun 5, 2020

Description

Fixes

Contributing Agreement

Uh oh!

willmeister left a comment

Choose a reason for hiding this comment

Uh oh!

willmeister Jun 5, 2020

Choose a reason for hiding this comment

Uh oh!

willmeister Jun 5, 2020

Choose a reason for hiding this comment

Uh oh!

willmeister Jun 5, 2020

Choose a reason for hiding this comment

Uh oh!

willmeister Jun 5, 2020

Choose a reason for hiding this comment

Uh oh!

willmeister Jun 5, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants