Skip to content

feat: fast-follow changes for interop portal updates#14778

Closed
smartcontracts wants to merge 3 commits intodevelopfrom
sc/interop-portal-fast-follow
Closed

feat: fast-follow changes for interop portal updates#14778
smartcontracts wants to merge 3 commits intodevelopfrom
sc/interop-portal-fast-follow

Conversation

@smartcontracts
Copy link
Contributor

Includes a number of important updates for the interop portal changes, including:

  • Removal of Interop versions of contracts and all associated scripts and utilities.
  • Updated migration function for the OptimismPortal contract.
  • Updated ETHLockbox initializer with better checks on each OptimismPortal contract being approved.

Includes a number of important updates for the interop portal
changes, including:
- Removal of Interop versions of contracts and all associated
  scripts and utilities.
- Updated migration function for the OptimismPortal contract.
- Updated ETHLockbox initializer with better checks on each
  OptimismPortal contract being approved.
@smartcontracts smartcontracts requested review from a team as code owners March 11, 2025 03:43
@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.45%. Comparing base (cbe9921) to head (6ee54b0).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
packages/contracts-bedrock/src/L1/ETHLockbox.sol 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14778      +/-   ##
===========================================
- Coverage    46.55%   45.45%   -1.10%     
===========================================
  Files         1049      987      -62     
  Lines        90835    86095    -4740     
===========================================
- Hits         42285    39138    -3147     
+ Misses       45429    44002    -1427     
+ Partials      3121     2955     -166     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 94.35% <95.65%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-chain-ops/interopgen/configs.go 25.00% <ø> (ø)
op-chain-ops/interopgen/deploy.go 72.42% <100.00%> (-0.11%) ⬇️
op-chain-ops/interopgen/recipe.go 75.95% <100.00%> (-0.10%) ⬇️
op-deployer/pkg/deployer/opcm/implementations.go 0.00% <ø> (ø)
op-deployer/pkg/deployer/opcm/opchain.go 0.00% <ø> (ø)
op-deployer/pkg/deployer/pipeline/opchain.go 87.06% <100.00%> (-0.22%) ⬇️
op-deployer/pkg/deployer/standard/standard.go 41.74% <ø> (ø)
op-deployer/pkg/deployer/state/chain_intent.go 82.35% <ø> (ø)
...ontracts-bedrock/scripts/checks/interfaces/main.go 54.72% <ø> (ø)
...es/contracts-bedrock/src/L1/OPContractsManager.sol 97.48% <100.00%> (-0.04%) ⬇️
... and 2 more

... and 70 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@maurelian maurelian Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add this test in this file just to make codecov happy about the uncovered the version getter?

    /// @notice Tests that the version function returns a valid string. We avoid testing the
    ///         specific value of the string as it changes frequently.
    function test_version_succeeds() external view {
        assert(bytes(ethLockbox.version()).length > 0);
    }

@smartcontracts
Copy link
Contributor Author

Closing in favor of #14785

@smartcontracts smartcontracts deleted the sc/interop-portal-fast-follow branch March 11, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants