feat: fast-follow changes for interop portal updates#14778
Closed
smartcontracts wants to merge 3 commits intodevelopfrom
Closed
feat: fast-follow changes for interop portal updates#14778smartcontracts wants to merge 3 commits intodevelopfrom
smartcontracts wants to merge 3 commits intodevelopfrom
Conversation
Includes a number of important updates for the interop portal changes, including: - Removal of Interop versions of contracts and all associated scripts and utilities. - Updated migration function for the OptimismPortal contract. - Updated ETHLockbox initializer with better checks on each OptimismPortal contract being approved.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14778 +/- ##
===========================================
- Coverage 46.55% 45.45% -1.10%
===========================================
Files 1049 987 -62
Lines 90835 86095 -4740
===========================================
- Hits 42285 39138 -3147
+ Misses 45429 44002 -1427
+ Partials 3121 2955 -166
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
maurelian
reviewed
Mar 11, 2025
Contributor
There was a problem hiding this comment.
Can you please add this test in this file just to make codecov happy about the uncovered the version getter?
/// @notice Tests that the version function returns a valid string. We avoid testing the
/// specific value of the string as it changes frequently.
function test_version_succeeds() external view {
assert(bytes(ethLockbox.version()).length > 0);
}
Contributor
Author
|
Closing in favor of #14785 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes a number of important updates for the interop portal changes, including: