feat: add Super Root specific method to OptimismPortal#14532
Merged
smartcontracts merged 1 commit intofeat/interop-portal-updatesfrom Mar 3, 2025
Merged
feat: add Super Root specific method to OptimismPortal#14532smartcontracts merged 1 commit intofeat/interop-portal-updatesfrom
smartcontracts merged 1 commit intofeat/interop-portal-updatesfrom
Conversation
smartcontracts
force-pushed
the
sc/pwd-super-roots
branch
from
7212d9c to
710cdce
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/interop-portal-updates #14532 +/- ##
================================================================
- Coverage 81.54% 45.41% -36.13%
================================================================
Files 171 981 +810
Lines 9960 84460 +74500
================================================================
+ Hits 8122 38359 +30237
- Misses 1670 43189 +41519
- Partials 168 2912 +2744
Flags with carried forward coverage won't be shown. Click here to find out more.
|
smartcontracts
force-pushed
the
sc/pwd-super-roots
branch
4 times, most recently
from
d8e738b to
e376c05
Compare
smartcontracts
force-pushed
the
sc/asr-sot
branch
from
0572e01 to
1b92ea2
Compare
smartcontracts
force-pushed
the
sc/pwd-super-roots
branch
3 times, most recently
from
eb841eb to
cc6ad30
Compare
smartcontracts
force-pushed
the
sc/asr-sot
branch
from
1b92ea2 to
0fedf0c
Compare
smartcontracts
force-pushed
the
sc/pwd-super-roots
branch
from
cc6ad30 to
70c0046
Compare
smartcontracts
force-pushed
the
sc/asr-sot
branch
from
0fedf0c to
278d58f
Compare
smartcontracts
force-pushed
the
sc/pwd-super-roots
branch
from
70c0046 to
749e533
Compare
smartcontracts
force-pushed
the
sc/asr-sot
branch
from
278d58f to
ad0ae2a
Compare
smartcontracts
force-pushed
the
sc/pwd-super-roots
branch
from
749e533 to
42f3374
Compare
smartcontracts
force-pushed
the
sc/asr-sot
branch
from
ad0ae2a to
66f0890
Compare
smartcontracts
force-pushed
the
sc/pwd-super-roots
branch
from
42f3374 to
68faef2
Compare
smartcontracts
force-pushed
the
sc/asr-sot
branch
2 times, most recently
from
f9ab615 to
6f633e1
Compare
smartcontracts
force-pushed
the
sc/pwd-super-roots
branch
from
68faef2 to
8a98aef
Compare
maurelian
reviewed
Feb 26, 2025
smartcontracts
force-pushed
the
sc/asr-sot
branch
3 times, most recently
from
6db3d67 to
1040c51
Compare
smartcontracts
force-pushed
the
sc/pwd-super-roots
branch
3 times, most recently
from
1041722 to
1a6c9c3
Compare
maurelian
reviewed
Feb 27, 2025
Comment on lines
362
to
379
| if (_isProxy) { | ||
| require(val == 1, "DeployUtils: storage value is not 1 at the given slot and offset"); | ||
| require( | ||
| val >= 1 && val < type(uint8).max, "DeployUtils: storage value is not set at the given slot and offset" | ||
| ); | ||
| } else { | ||
| require(val == type(uint8).max, "DeployUtils: storage value is not 0xff at the given slot and offset"); | ||
| } |
Contributor
There was a problem hiding this comment.
these two blocks just boil down to require(val>0), which doesn't tell us much in a world with reinitializers.
WDYT about making the reinitializer value a public constant in the bytecode, then we can check that the slotVal matches either that value of the max uint8. ie.
uint public constant initVersion;
function initialize() reinitializer(initVersion) {}
function upgrade() reinitializer(initVersion) {}
Contributor
Author
There was a problem hiding this comment.
Resolved with a new dedicated contract for this
smartcontracts
requested review from
axelKingsley and
maurelian
and removed request for
a team
smartcontracts
force-pushed
the
feat/interop-portal-updates
branch
3 times, most recently
from
402ded5 to
159fb05
Compare
Contributor
ControlCplusControlV
left a comment
ControlCplusControlV
left a comment
There was a problem hiding this comment.
Adding note - reviewed the Solidity and didn't have any comments, but planning to revisit. The overall design lgtm though
smartcontracts
force-pushed
the
sc/pwd-super-roots
branch
from
c5eafb2 to
5906d4d
Compare
smartcontracts
commented
Feb 28, 2025
smartcontracts
commented
Feb 28, 2025
smartcontracts
commented
Feb 28, 2025
packages/contracts-bedrock/snapshots/storageLayout/Reinitializable.json
Outdated
Show resolved
Hide resolved
smartcontracts
commented
Feb 28, 2025
smartcontracts
commented
Feb 28, 2025
smartcontracts
commented
Feb 28, 2025
smartcontracts
force-pushed
the
sc/pwd-super-roots
branch
from
5906d4d to
831419f
Compare
mds1
reviewed
Feb 28, 2025
mds1
reviewed
Feb 28, 2025
mds1
reviewed
Feb 28, 2025
mds1
reviewed
Feb 28, 2025
mds1
reviewed
Feb 28, 2025
mds1
approved these changes
Feb 28, 2025
Updates the OptimismPortal to include a method that allows users to prove against Super Roots for interop.
smartcontracts
force-pushed
the
sc/pwd-super-roots
branch
from
831419f to
540c870
Compare
ControlCplusControlV
approved these changes
Mar 3, 2025
maurelian
approved these changes
Mar 3, 2025
maurelian
approved these changes
Mar 3, 2025
maurelian
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the OptimismPortal to include a method that allows users to prove against Super Roots for interop.