Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #14512 +/- ##
============================================
- Coverage 77.23% 41.97% -35.27%
============================================
Files 178 859 +681
Lines 10649 78476 +67827
============================================
+ Hits 8225 32939 +24714
- Misses 2243 42644 +40401
- Partials 181 2893 +2712
Flags with carried forward coverage won't be shown. Click here to find out more. |
janjakubnanista
requested changes
Feb 25, 2025
|
|
||
| func AcquireLowLevelSystem() (LowLevelSystemGetter, systest.PreconditionValidator) { | ||
| sysMarker := &struct{}{} | ||
| sysMarker := newSentinelMarker() |
Contributor
There was a problem hiding this comment.
I think you should just be able to use new(byte) instead of &struct{}{} instead of keeping a global counter or?
I made that fix and validated it by a run in the external devnet-sdk testing repo, see description in the PR #14514
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The code was wrongly assuming that the compiler didn't optimize out
separate pointers pointing to an identical object.
Tests
Additional context
Metadata